Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.1.6, 2.2.3, 2.3
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      I think for this one, reviewing the patch is enough.

      If you like, you can work out where in the UI these strings are displayed, and look at them there.

      Show
      I think for this one, reviewing the patch is enough. If you like, you can work out where in the UI these strings are displayed, and look at them there.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      39412

      Description

      See parent task.

        Activity

        Hide
        Tim Hunt added a comment -

        Should we back-port this to earlier branches?

        Show
        Tim Hunt added a comment - Should we back-port this to earlier branches?
        Hide
        Helen Foster added a comment -

        Hi Tim,

        The pull master diff URL https://github.com/timhunt/moodle/compare/master...MDL-32519 listed 30 commits, however I found https://github.com/timhunt/moodle/commit/08de98c40df978755d9a40bdb1c14d00a29577fa with 2 changes which look fine to me.

        Show
        Helen Foster added a comment - Hi Tim, The pull master diff URL https://github.com/timhunt/moodle/compare/master...MDL-32519 listed 30 commits, however I found https://github.com/timhunt/moodle/commit/08de98c40df978755d9a40bdb1c14d00a29577fa with 2 changes which look fine to me.
        Hide
        Tim Hunt added a comment -

        Oops yes. I will clean up that mess and then submit for integration.

        Show
        Tim Hunt added a comment - Oops yes. I will clean up that mess and then submit for integration.
        Hide
        Dan Poltawski added a comment -

        Thanks Tim, that has been integrated now

        Show
        Dan Poltawski added a comment - Thanks Tim, that has been integrated now
        Hide
        Dan Poltawski added a comment -

        Damn. Just noticed I missed a typo in your commit message!

        Show
        Dan Poltawski added a comment - Damn. Just noticed I missed a typo in your commit message!
        Hide
        Ankit Agarwal added a comment -

        Changes are straight forward and looks good
        Thanks

        Show
        Ankit Agarwal added a comment - Changes are straight forward and looks good Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: