Moodle
  1. Moodle
  2. MDL-32530

RTL Theme fixes for Moodle 2 (theme/arialist)

    Details

      Description

      Right align course's title
      theme/arialist/style/core.css

      Notes:

      1. DOCK is right aligned correctly due to parent theme/base css code
      2. I have left the "above header custom menu" justified to the left since it works best this way.
      3. No need to switch blocks columns since this theme has one blocks column (to the right)

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Nadav, is this issue still requiring work or can it be closed? I notice that the diff URL is broken.

          Show
          Andrew Davis added a comment - Nadav, is this issue still requiring work or can it be closed? I notice that the diff URL is broken.
          Hide
          Nadav Kavalerchik added a comment -

          It is still a minor issue.

          But I read somewhere that Martin Dougiamas decided to deprecate all non-boorstrapbased themes in Moodle 2.7
          So I do not think we should bother with it. Am I right?
          (Same goes for several other issues I saw you recently querying about, regarding RTL issues)

          Show
          Nadav Kavalerchik added a comment - It is still a minor issue. But I read somewhere that Martin Dougiamas decided to deprecate all non-boorstrapbased themes in Moodle 2.7 So I do not think we should bother with it. Am I right? (Same goes for several other issues I saw you recently querying about, regarding RTL issues)
          Hide
          Mary Evans added a comment - - edited

          These may as well get closed. I did not realise how many there were here, however, technically these should get fixed in either base theme or canvas, which one way or another should fix all of them.

          The menu is the biggest problem, but at least this went into Afterburner and Anomaly.

          If there are some issues Nadav then it would be best to fix theme regardless of these themes being depreciated. They will be still available in the Plugins Database and as far as I know base theme will stay because of Standard theme, I am not too sure about Canvas theme yet, but I guess that will stay too to keep Sky High or Splash ticking over, but I am not sure whch themes are going and which are staying. It may be all the standard Moodle themes go and new and different ones appear. I just don't know.

          Show
          Mary Evans added a comment - - edited These may as well get closed. I did not realise how many there were here, however, technically these should get fixed in either base theme or canvas, which one way or another should fix all of them. The menu is the biggest problem, but at least this went into Afterburner and Anomaly. If there are some issues Nadav then it would be best to fix theme regardless of these themes being depreciated. They will be still available in the Plugins Database and as far as I know base theme will stay because of Standard theme, I am not too sure about Canvas theme yet, but I guess that will stay too to keep Sky High or Splash ticking over, but I am not sure whch themes are going and which are staying. It may be all the standard Moodle themes go and new and different ones appear. I just don't know.
          Hide
          Andrew Davis added a comment -

          As Mary says, if any themes are removed from core they will be moved into the plugins database so any work done on them will not be lost. If fixes are available, they are still worth trying to get integrated. Alternatively, they can be made after the theme(s) are moved to the plugins database.

          I will close this particular MDL as it is currently lacking either a solution or a description of the specific problem. Nadav, if you do have any fixes around, feel free to open new MDLs and post them as they are appreciated.

          Show
          Andrew Davis added a comment - As Mary says, if any themes are removed from core they will be moved into the plugins database so any work done on them will not be lost. If fixes are available, they are still worth trying to get integrated. Alternatively, they can be made after the theme(s) are moved to the plugins database. I will close this particular MDL as it is currently lacking either a solution or a description of the specific problem. Nadav, if you do have any fixes around, feel free to open new MDLs and post them as they are appreciated.
          Hide
          Nadav Kavalerchik added a comment -

          I see.
          It is an easy fix. I will do it next week.
          (just came back from a short vocation, and I am flooded with pending issues)

          Show
          Nadav Kavalerchik added a comment - I see. It is an easy fix. I will do it next week. (just came back from a short vocation, and I am flooded with pending issues)

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: