Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32533

Replace heading with notification in Language customization

    Details

      Description

      Change the 'nostringsfound' text in the file admin/tool/customlang/renderer.php to print as notification.

      In the line 56:

      return $this->heading(get_string('nostringsfound', 'tool_customlang'), 3);

      Add global $OUTPUT to the function and change the line 56 to:

      return $OUTPUT->notification(get_string('nostringsfound', 'tool_customlang'));

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for spotting that.

          Show
          salvetore Michael de Raadt added a comment - Thanks for spotting that.
          Hide
          poltawski Dan Poltawski added a comment -

          This is fairly trivial, but I suppose its bad for accessibility to use headings like this, so here i submit the issue for review.

          Show
          poltawski Dan Poltawski added a comment - This is fairly trivial, but I suppose its bad for accessibility to use headings like this, so here i submit the issue for review.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Dan - this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Dan - this has been integrated now.
          Hide
          damyon Damyon Wiese added a comment -

          Passed - I can see the error.

          Show
          damyon Damyon Wiese added a comment - Passed - I can see the error.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          (looks like this has been passed - sorry if I'm wrong)

          Show
          samhemelryk Sam Hemelryk added a comment - (looks like this has been passed - sorry if I'm wrong)
          Hide
          marina Marina Glancy added a comment -

          Thanks for your awesome work! This has now become a part of Moodle.

          Closing as fixed!

          Show
          marina Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13