Regression: course completion report download shows {$a} unused placeholder when activities auto completion is set

Regression was caused by MDL-30817 (which incidentally wasn't my code). Looking into it...

OK, there are two issues here:

1) The course completion report (this is course completion, not activity completion, so not really my problem but I will fix it anyway) was inappropriately using strings intended for alt text for a different purpose. The activity completion report (which is my problem) does the same thing.

2) The strings for alt text were not fully changed (the 'fail/pass' ones were missed out, a couple others in editing mode).

I think we need to duplicate the strings for use with course completion report (and if anywhere else wants them) as a generic description when not used as alt text. (Note that this is not literally duplicating the strings, the strings are different as they don't have the {$a} in.)

I am writing a test script but this will only cover activity completion and not course completion because I am not actually familiar with that. The change should be pretty safe as I search/replaced the string names, but if somebody is able to add to the test script, that would be helpful.

Think this fix (and test script included) pretty much covers it...

Sam, thanks for your amazing fast fix

Thank you Andrea for forwarding me to this bug report from my post: http://moodle.org/mod/forum/discuss.php?d=201486

Thank you Sam for providing a patch for the problem, I've just applied it to my own installation and it has resolved the problem.

We followed test instructions an everything performed as expectd, "$a" is no more visible in course completion report. Sending to integration review.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Rebased (master branch only, 2.2 is probably stable anyway) - no conflicts

Hi Sam,

Should this fix be backported to 2.1 (seems to cherr-pick cleanly)

Dan: I didn't think of that because it was reported against 2.x - but yes I think it should since it was caused by MDL-30817 which went into 2.1. (I had a look at the commit for that, it seems same on all branches too.)

Integrated, thanks

Once completed the alt texts and icons (completion-alt-auto-pass, completion-alt-auto-fail) for the quizzes did not come up as expected. The completion-alt-auto-y was used instead.

The same wrong texts are present in the CSV export.

Everything else worked just fine.

This is just me but why are the alt attributes more verbose than the title ones? Why aren't they similar?

Regarding pass grade not working - looking at it.

Regarding alt/title: The alt attributes are there for accessibility reasons and are primarily intended for people using screen readers. Title attributes are there for sighted people who hover over the item and want to know what it does. Often they are indeed the same but there can be differences because typically, titles are there to describe what happens if you click something, whereas alt text is there to describe the meaning of the thing as well.

In this case, for example, title text is:

'Mark as complete: [activity]'.

Alt text is:

'Not completed:

. Select to mark as complete.'

So the alt text tells you the current state first (which a sighted person could see just by looking that the icon is not ticked) and then tells you that you can click, whoops, 'select' to mark it complete. The title only has to tell you the second part.

I just tested this again using my branch. Specifically I did a shortened version of the test:

1. Restore the attached backup file as a new course.

3. Turn editing off. Enrol a test account into the course as a student. Log in as the test account.

7. Do the second quiz. Get it right. Return to course page - quiz should have green tick. Confirm alt text 'Completed: The answer is 42 (pass grade) (achieved pass grade)'
NOTE: Confusing text here is because I put '(pass grade)' at end of activity name, sorry.

9. Log back in as admin. Go to Reports / Activity completion. Save as .csv.

Before doing the test, I went to admin and 'purge all caches' (this was necessary because I didn't have a version update to clear caches, I don't think it should have been needed on test system).

When I did this on my system using this branch, the icon for the second quiz correctly appeared as a green tick (not a default red one) and the alt text was as described in the test case, and the csv file had 'Completed (achieved pass grade)'. So I think it is working. Are you saying that isn't the case for you?

I'm giving this one more testing iteration...

Tested under 21_STABLE and master. Everything went ok (one small difference was found in the .csv file, but was verified with SamM).

So passing. Thanks and ciao

U P S T R E A M I Z E D !

Many thanks for the hard work, closing this as fixed.

Ciao

Hi guys,

My bad, I should have mentioned that (for some obscure reason) I could not load the backup. I manually recreated it but I was probably wrong somewhere. Sorry about all that! Although, realising this this morning, I imported and tested once more. It appears that when succeeding the first quiz on the first attempt, the icon is a red tick. I know that this has been integrated, but I thought that you might be interested in knowing that minor little issue.

Cheers!

About the alt text 'Not completed:

. Select to mark as complete' in the report, in my opinion the sentence is misleading. In the course completion report AFAIK there is no way to select an activity to mark it as complete. Or I'm wrong somewhere?

Andrea: Does it use that alt text that you quoted in the activity completion report? I thought it had different alt text in the report, but maybe not.

If it does use that alt text, I agree that would be another bug, please file new issue if you want and I'll fix it...

Sam,
checked again using latest lang pack and moodle versions, you are right, alt text in the report appears appropriate, I apologize for the false alarm (blush).

thanks. and yay, I've had enough of fiddling with these strings

Fred, but testing instructions (point 6) say exactly that one red tick is expected, isn't it?