Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32543

After an update in some circumstances the field size of mdl_log.action is smaller than log_display.action

    Details

    • Testing Instructions:
      Hide
      1. Before upgrade manually alter your database:
        1. Set log.action precision to 20
        2. Set log.url precision to 50
      2. Run the upgrade
      3. Check that log.action precision is 40
      4. Check that log.url precision is 100
      5. Dump the database structure of the log table to a file (fixed.sql)
      6. Install a fresh site from the last weekly release.
      7. Dump the database structure of the log table to a file (before.sql)
      8. Update the code to the integration branch
      9. Run the upgrade
      10. Dump the database structure of the log table to a file (after.sql)
      11. Diff the three (fixed, before, after) files and ensure there are absolutely no differences.
      Show
      Before upgrade manually alter your database: Set log.action precision to 20 Set log.url precision to 50 Run the upgrade Check that log.action precision is 40 Check that log.url precision is 100 Dump the database structure of the log table to a file (fixed.sql) Install a fresh site from the last weekly release. Dump the database structure of the log table to a file (before.sql) Update the code to the integration branch Run the upgrade Dump the database structure of the log table to a file (after.sql) Diff the three (fixed, before, after) files and ensure there are absolutely no differences.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      After an update from moodle 1.9 to 2.x in some circumstances the field size of mdl_log.action is to small.
      In our especially case the size of this field is 15 but it has to be 40.
      If the quiz-module tries to write a log entry while a user is continuing a quiz the action value is "continue attempt".
      This value has a length of 16 chars and throws a dml_write_exception.
      I think there are more cases than mentioned here.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  3 Vote for this issue
                  Watchers:
                  10 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Jul/14