Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32564

Missing page context on admin/timezone.php

    Details

      Description

      Ankit noticed the following error on admin/timezone.php while reviewing MDL-30843:

      $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report.

            Show
            skodak Petr Skoda added a comment - Thanks for the report.
            Hide
            poltawski Dan Poltawski added a comment -

            Petr, we are still supporting 2.1 for bugfixes. Please could you provide a fix for 2.1

            Show
            poltawski Dan Poltawski added a comment - Petr, we are still supporting 2.1 for bugfixes. Please could you provide a fix for 2.1
            Hide
            poltawski Dan Poltawski added a comment -

            Reopening since I assume this fixes 2.1 too.

            Show
            poltawski Dan Poltawski added a comment - Reopening since I assume this fixes 2.1 too.
            Hide
            skodak Petr Skoda added a comment -

            Hi, I did not think minor debug notices need to be backported everywhere, anyway I have added cherry-picked fix for 2.1 too. Thanks.

            Show
            skodak Petr Skoda added a comment - Hi, I did not think minor debug notices need to be backported everywhere, anyway I have added cherry-picked fix for 2.1 too. Thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            context_system doesn't exist in 2.1, which is why I didn't cherry-pick thus myself.

            Show
            poltawski Dan Poltawski added a comment - context_system doesn't exist in 2.1, which is why I didn't cherry-pick thus myself.
            Hide
            skodak Petr Skoda added a comment -

            fixed, sorry.

            Show
            skodak Petr Skoda added a comment - fixed, sorry.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks, itnegrated now

            Show
            poltawski Dan Poltawski added a comment - Thanks, itnegrated now
            Hide
            fred Frédéric Massart added a comment -

            Test successful on 2.1, 2.2 and master

            Show
            fred Frédéric Massart added a comment - Test successful on 2.1, 2.2 and master
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12