Moodle
  1. Moodle
  2. MDL-32564

Missing page context on admin/timezone.php

        Details

          Description

          Ankit noticed the following error on admin/timezone.php while reviewing MDL-30843:

          $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context()

            Gliffy Diagrams

              Issue Links

              Testing discovered

              Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30843 select input elements are missing labels

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Petr Skoda added a comment -

                Thanks for the report.

                Show
                Petr Skoda added a comment - Thanks for the report.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Petr, we are still supporting 2.1 for bugfixes. Please could you provide a fix for 2.1

                Show
                Dan Poltawski added a comment - Petr, we are still supporting 2.1 for bugfixes. Please could you provide a fix for 2.1
                Hide
                Permalink
                Dan Poltawski added a comment -

                Reopening since I assume this fixes 2.1 too.

                Show
                Dan Poltawski added a comment - Reopening since I assume this fixes 2.1 too.
                Hide
                Permalink
                Petr Skoda added a comment -

                Hi, I did not think minor debug notices need to be backported everywhere, anyway I have added cherry-picked fix for 2.1 too. Thanks.

                Show
                Petr Skoda added a comment - Hi, I did not think minor debug notices need to be backported everywhere, anyway I have added cherry-picked fix for 2.1 too. Thanks.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                TIA and ciao

                Show
                Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                Hide
                Permalink
                Dan Poltawski added a comment -

                context_system doesn't exist in 2.1, which is why I didn't cherry-pick thus myself.

                Show
                Dan Poltawski added a comment - context_system doesn't exist in 2.1, which is why I didn't cherry-pick thus myself.
                Hide
                Permalink
                Petr Skoda added a comment -

                fixed, sorry.

                Show
                Petr Skoda added a comment - fixed, sorry.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Thanks, itnegrated now

                Show
                Dan Poltawski added a comment - Thanks, itnegrated now
                Hide
                Permalink
                Frédéric Massart added a comment -

                Test successful on 2.1, 2.2 and master

                Show
                Frédéric Massart added a comment - Test successful on 2.1, 2.2 and master
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

                Thanks!

                Show
                Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: