Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.2
-
Component/s: Administration
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:w21_
MDL-32564_m23_timezonecontext -
Pull Master Diff URL:
Description
Ankit noticed the following error on admin/timezone.php while reviewing MDL-30843:
$PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context()
|
Gliffy Diagrams
Attachments
Issue Links
- Testing discovered
-
MDL-30843 select input elements are missing labels
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Petr, we are still supporting 2.1 for bugfixes. Please could you provide a fix for 2.1
Reopening since I assume this fixes 2.1 too.
Hi, I did not think minor debug notices need to be backported everywhere, anyway I have added cherry-picked fix for 2.1 too. Thanks.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
context_system doesn't exist in 2.1, which is why I didn't cherry-pick thus myself.
fixed, sorry.
Thanks, itnegrated now
Test successful on 2.1, 2.2 and master
This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).
Thanks!
Thanks for the report.