Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32566

The change in the order of canvas and base in FW $THEME->parents messed up the login block

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Compare the old and the new look of the login block with the attached images.
      Take care because all has to work even changing theme blockcolumnwidth and blockpadding.
      Cases are really a lot (# of blockcolumnwidth * # of blockpadding * # of browser) but the procedure I used in function formal_white_set_blockpadding of lib.php is linear (in mathematical sense: power of variable is never greater than 1) so I tested only the two extreme cases in FF and chrome and I totally trust all cases are correct.
      Even icons and texts alignment needs to be tested. I worked on "Main menu", "Navigation block" and "Login block".

      Show
      Compare the old and the new look of the login block with the attached images. Take care because all has to work even changing theme blockcolumnwidth and blockpadding. Cases are really a lot (# of blockcolumnwidth * # of blockpadding * # of browser) but the procedure I used in function formal_white_set_blockpadding of lib.php is linear (in mathematical sense: power of variable is never greater than 1) so I tested only the two extreme cases in FF and chrome and I totally trust all cases are correct. Even icons and texts alignment needs to be tested. I worked on "Main menu", "Navigation block" and "Login block".
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32566_master

      Description

      look at attachments to see how the login block appears now and how it should appear after this integration.
      I hope this sounds as testing instruction too.

        Attachments

          Activity

            People

            Assignee:
            daniss Daniele Cordella
            Reporter:
            daniss Daniele Cordella
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12