Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32566

The change in the order of canvas and base in FW $THEME->parents messed up the login block

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Compare the old and the new look of the login block with the attached images.
      Take care because all has to work even changing theme blockcolumnwidth and blockpadding.
      Cases are really a lot (# of blockcolumnwidth * # of blockpadding * # of browser) but the procedure I used in function formal_white_set_blockpadding of lib.php is linear (in mathematical sense: power of variable is never greater than 1) so I tested only the two extreme cases in FF and chrome and I totally trust all cases are correct.
      Even icons and texts alignment needs to be tested. I worked on "Main menu", "Navigation block" and "Login block".

      Show
      Compare the old and the new look of the login block with the attached images. Take care because all has to work even changing theme blockcolumnwidth and blockpadding. Cases are really a lot (# of blockcolumnwidth * # of blockpadding * # of browser) but the procedure I used in function formal_white_set_blockpadding of lib.php is linear (in mathematical sense: power of variable is never greater than 1) so I tested only the two extreme cases in FF and chrome and I totally trust all cases are correct. Even icons and texts alignment needs to be tested. I worked on "Main menu", "Navigation block" and "Login block".
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32566_master

      Description

      look at attachments to see how the login block appears now and how it should appear after this integration.
      I hope this sounds as testing instruction too.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            daniss Daniele Cordella added a comment -

            Developing the fix for this issue I found two more aspect needing attention.
            1. .block_login #login_username, .block_login #login_password width depends from some static value.
            I unified the definition of this static values in improve theme maintainability.
            2. I found that horizontal alignment among icon and texts in "navigation block", "main menu block" and "login block" was not respected. I tried to fix it as I am showing in the last two attached pictures

            Show
            daniss Daniele Cordella added a comment - Developing the fix for this issue I found two more aspect needing attention. 1. .block_login #login_username, .block_login #login_password width depends from some static value. I unified the definition of this static values in improve theme maintainability. 2. I found that horizontal alignment among icon and texts in "navigation block", "main menu block" and "login block" was not respected. I tried to fix it as I am showing in the last two attached pictures
            Hide
            poltawski Dan Poltawski added a comment -

            Reopening as requested

            Show
            poltawski Dan Poltawski added a comment - Reopening as requested
            Hide
            daniss Daniele Cordella added a comment -

            Just corrected the issue.
            Am I still in time?
            In any case, thanks all.

            Show
            daniss Daniele Cordella added a comment - Just corrected the issue. Am I still in time? In any case, thanks all.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (master). Thanks!

            I haven't looked at the details of your calculations, but I trust you, hehe.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (master). Thanks! I haven't looked at the details of your calculations, but I trust you, hehe.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I've tried IE7, Safari, Firefox and Chrome and both the login block and the icon and text alignments look ok.

            Only the username and password boxes are 2-3 points out from text alignment, but it seems to be the same in your images.

            So passing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I've tried IE7, Safari, Firefox and Chrome and both the login block and the icon and text alignments look ok. Only the username and password boxes are 2-3 points out from text alignment, but it seems to be the same in your images. So passing, thanks!
            Hide
            daniss Daniele Cordella added a comment -

            It is an honor to have you as a tester! Thanks ... [in your black week, in addition] (chuckle)

            Show
            daniss Daniele Cordella added a comment - It is an honor to have you as a tester! Thanks ... [in your black week, in addition] (chuckle)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This has been near becoming rejected, because it's not the best code you are able to produce.

            But, luckily, at the end, it has landed and has been spread to all repos out there.

            Many thanks and, don't forget it, keep improving your skills, you can!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12