Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Unit tests
    • Labels:
    • Rank:
      39478

      Description

      done:

      todo:

      • review builder new config by Eloy

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Petr,

          I've integrated this now. I just noticed you haven't mentioned anything about:

          lib/simpletest/broken_portfolio_testclass.php
          lib/simpletest/broken_testfiltermanager.php

          Are we just ignoring those?

          Show
          Dan Poltawski added a comment - Hi Petr, I've integrated this now. I just noticed you haven't mentioned anything about: lib/simpletest/broken_portfolio_testclass.php lib/simpletest/broken_testfiltermanager.php Are we just ignoring those?
          Hide
          Petr Škoda added a comment -

          ssshhh, but now that you asked, yes I kind of ignore them:

          • portfolio should be now testable, problem was that it relied in fakedb test class which was kind of reimplemented by the new phpunit support, I personally do nto want to deal with it
          • the filter manager is also a bit problematic because it alters dirroot, but I guess it can be fixed now because the new phpunit reset code can recover even from that
          Show
          Petr Škoda added a comment - ssshhh, but now that you asked, yes I kind of ignore them: portfolio should be now testable, problem was that it relied in fakedb test class which was kind of reimplemented by the new phpunit support, I personally do nto want to deal with it the filter manager is also a bit problematic because it alters dirroot, but I guess it can be fixed now because the new phpunit reset code can recover even from that
          Hide
          Michael de Raadt added a comment -

          I'm still running the PHPUnit tests on Oracle.

          I proofed the PHPUnit docs, including the Windows and Mac pages. I thought much of the content of the Windows and Mac pages was redundant and could be replaced by directing readers to already existing installation documentation. I think providing people with a sample config.php file is not a great idea as it could become outdated very quickly. I prefer to recommend a standard install and changing settings through the configuration.

          Show
          Michael de Raadt added a comment - I'm still running the PHPUnit tests on Oracle. I proofed the PHPUnit docs, including the Windows and Mac pages. I thought much of the content of the Windows and Mac pages was redundant and could be replaced by directing readers to already existing installation documentation. I think providing people with a sample config.php file is not a great idea as it could become outdated very quickly. I prefer to recommend a standard install and changing settings through the configuration.
          Hide
          Petr Škoda added a comment - - edited

          I disagree, there is nothing redundant because once you hit problems when making your dev install then you can not go through 3 guides and merge them in your head looking for one single line you forgot to do. The config is the smallest possible necessary for unit testing , it is not going to get outdated.

          Show
          Petr Škoda added a comment - - edited I disagree, there is nothing redundant because once you hit problems when making your dev install then you can not go through 3 guides and merge them in your head looking for one single line you forgot to do. The config is the smallest possible necessary for unit testing , it is not going to get outdated.
          Hide
          Petr Škoda added a comment - - edited

          Also in windows if you make one step differently you might end up with permission, path or version problems, etc. It really must be one guide with all necessary steps if you want to prevent confusion and reduce the initial installation time from 1 day to 1 hour.

          Show
          Petr Škoda added a comment - - edited Also in windows if you make one step differently you might end up with permission, path or version problems, etc. It really must be one guide with all necessary steps if you want to prevent confusion and reduce the initial installation time from 1 day to 1 hour.
          Hide
          Michael de Raadt added a comment -

          Test result: Success

          Apart from some know issues, the tests passed under all DBs.

          Show
          Michael de Raadt added a comment - Test result: Success Apart from some know issues, the tests passed under all DBs.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This has been near becoming rejected, because it's not the best code you are able to produce.

          But, luckily, at the end, it has landed and has been spread to all repos out there.

          Many thanks and, don't forget it, keep improving your skills, you can!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: