Moodle
  1. Moodle
  2. MDL-32576

import latest markdown PHP Markdown Extra 1.2.5

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:
      None

      Description

      fixes some PHP 5.3 issues

        Gliffy Diagrams

          Activity

          Hide
          Dan Poltawski added a comment -

          Thanks, i've integrated this now

          Show
          Dan Poltawski added a comment - Thanks, i've integrated this now
          Hide
          Michael de Raadt added a comment -

          After about three hours, the PHPUnit tests are still only ~60% done and I have to go. I will continue this when I get home.

          Show
          Michael de Raadt added a comment - After about three hours, the PHPUnit tests are still only ~60% done and I have to go. I will continue this when I get home.
          Hide
          Michael de Raadt added a comment -

          Test result: Success

          I ran the PHPUnit tests under all DBs and, apart from some know issues, they passed.

          Show
          Michael de Raadt added a comment - Test result: Success I ran the PHPUnit tests under all DBs and, apart from some know issues, they passed.
          Hide
          Michael de Raadt added a comment -

          I was wondering if there was a way we could test the functionality of this change. We shouldn't rely on unit tests alone if we don't have to.

          Show
          Michael de Raadt added a comment - I was wondering if there was a way we could test the functionality of this change. We shouldn't rely on unit tests alone if we don't have to.
          Hide
          Petr Skoda added a comment -

          If you want to test it manually then you need to select markdown and type for example forum post. You need to disable html editor first in the user preferences of course because we do not allow on-the-fly format switching in html editor...

          Show
          Petr Skoda added a comment - If you want to test it manually then you need to select markdown and type for example forum post. You need to disable html editor first in the user preferences of course because we do not allow on-the-fly format switching in html editor...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This has been near becoming rejected, because it's not the best code you are able to produce.

          But, luckily, at the end, it has landed and has been spread to all repos out there.

          Many thanks and, don't forget it, keep improving your skills, you can!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: