Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32578

few simple issues on formal_white strings

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      verify the framemargindesc message and the blockcolumnwidthdesc message in formal_white setting page.
      They should appear as they are described in the description of this issue

      Show
      verify the framemargindesc message and the blockcolumnwidthdesc message in formal_white setting page. They should appear as they are described in the description of this issue
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32578_master

      Description

      to make more accurate the translation of the string
      $string['framemargindesc']
      it should be changed from
      'Room between the frame and the edge of the browser window. (This setting will be ignored whether "Formal white 1.9 look" is requested).';
      to
      'Room between the frame and the edge of the browser window. (This setting will be ignored whether "{$a}" is requested).';
      and, of course, the calling code should change according to this change.

      With the introduction of the theme 'theme_formal_white/blockpadding' setting
      the string
      $string['blockcolumnwidthdesc']
      should change from
      'This sets the blocks column width for the theme. <strong>Using widths lower than 200px, the calendar block is not supposed to fit.</strong>';
      to
      'This sets the blocks column width for the theme. <strong>Leaving width lower than 200px (blockcolumnwidth-2*blockpadding), the calendar block is not supposed to fit.</strong>';

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12