Moodle

MP3 Flow Player doesn't work in Chrome if empty stylesheets are present

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 2.0.8, 2.1.5, 2.2.2
  • Fix Version/s: None
  • Component/s: Filters
  • Labels:
  • Testing Instructions:
    Hide

    Whilst Moodle itself generally won't include empty stylesheets, some Chrome extensions (including Google's screenshot tool, https://chrome.google.com/webstore/detail/cpngackimfmofbokmjmljamhdncknpmg) can inject empty stylesheets into the page - the aforementioned screenshot tool was the culprit in my case. I guess that's one way to test this - install that extension (it's handy to have anyway!).

    Show
    Whilst Moodle itself generally won't include empty stylesheets, some Chrome extensions (including Google's screenshot tool, https://chrome.google.com/webstore/detail/cpngackimfmofbokmjmljamhdncknpmg ) can inject empty stylesheets into the page - the aforementioned screenshot tool was the culprit in my case. I guess that's one way to test this - install that extension (it's handy to have anyway!).
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-32582_master
  • Pull Master Diff URL:

Description

If any empty stylesheets are present, Chrome will not display the MP3 Flow Player. This is similar to MDL-29980, though happened after the MDL-26697 changes were merged.

A quick and easy fix is to add the following line just after line 1712 of /lib/javascript-static.js (as per current master) - i.e. between the if and the for loop:

if (!allrules) continue;

Issue Links

duplicates

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32310 mediaplugin mp3 player not shown in chrome

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
will be (partly) resolved by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30876 MP3 player not shown when use external YUI enabled

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Nicholls added a comment -

Added pull details

Show
Paul Nicholls added a comment - Added pull details
Hide
Permalink
Michael de Raadt added a comment -

Thanks for spotting that and providing a fix.

Show
Michael de Raadt added a comment - Thanks for spotting that and providing a fix.
Hide
Permalink
Michael de Raadt added a comment -

This looks like a duplicate of an earlier issue, although you may have solved the cause of the mystery. I'm going to close this issue. Please contribute to the linked duplicate issue.

Show
Michael de Raadt added a comment - This looks like a duplicate of an earlier issue, although you may have solved the cause of the mystery. I'm going to close this issue. Please contribute to the linked duplicate issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: