Moodle
  1. Moodle
  2. MDL-32586

silence buggy glibc iconv with //IGNORE in fix_utf8()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:

      Description

      the title says all

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Thanks Petr i've integrated this now.

            Raj was having a problem with this test so this might be a good candidate to test this.

            Show
            Dan Poltawski added a comment - Thanks Petr i've integrated this now. Raj was having a problem with this test so this might be a good candidate to test this.
            Hide
            Michael de Raadt added a comment -

            Can I request that if there are specific unit tests we can run, that these be listed in the testing instructions. For most DBs it's not much of a problem running the PHPUnit tests, but for Oracle, this takes 5+ hours.

            Show
            Michael de Raadt added a comment - Can I request that if there are specific unit tests we can run, that these be listed in the testing instructions. For most DBs it's not much of a problem running the PHPUnit tests, but for Oracle, this takes 5+ hours.
            Hide
            Petr Skoda added a comment -

            Hmm, in general the point is to run all tests to verify there are no regressions introduced elsewhere. I will see what can be done with oracle performance later this week (If I somehow make it work here).

            Show
            Petr Skoda added a comment - Hmm, in general the point is to run all tests to verify there are no regressions introduced elsewhere. I will see what can be done with oracle performance later this week (If I somehow make it work here).
            Hide
            Michael de Raadt added a comment -

            True, you're right, Petr.

            Thanks, for looking at the performance of the tests.

            Show
            Michael de Raadt added a comment - True, you're right, Petr. Thanks, for looking at the performance of the tests.
            Hide
            Michael de Raadt added a comment -

            I've run the PHPUnit tests in SQL Server, MySQL and PostgreSQL. There were a couple of SQL related fails in MySQL and SQL Server, but I don't think they're related.

            I'm starting to run these under Oracle.

            Show
            Michael de Raadt added a comment - I've run the PHPUnit tests in SQL Server, MySQL and PostgreSQL. There were a couple of SQL related fails in MySQL and SQL Server, but I don't think they're related. I'm starting to run these under Oracle.
            Hide
            Michael de Raadt added a comment -

            Test result: Success

            Show
            Michael de Raadt added a comment - Test result: Success
            Hide
            Eloy Lafuente (stronk7) added a comment -

            UPDATE tracker_issues
               SET status = 'Closed',
                  comment = 'Thanks!'
            WHEN participants = 'Did a gorgeous work'
            

            This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

            Show
            Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: