Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32586

silence buggy glibc iconv with //IGNORE in fix_utf8()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:

      Description

      the title says all

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Petr i've integrated this now.

              Raj was having a problem with this test so this might be a good candidate to test this.

              Show
              poltawski Dan Poltawski added a comment - Thanks Petr i've integrated this now. Raj was having a problem with this test so this might be a good candidate to test this.
              Hide
              salvetore Michael de Raadt added a comment -

              Can I request that if there are specific unit tests we can run, that these be listed in the testing instructions. For most DBs it's not much of a problem running the PHPUnit tests, but for Oracle, this takes 5+ hours.

              Show
              salvetore Michael de Raadt added a comment - Can I request that if there are specific unit tests we can run, that these be listed in the testing instructions. For most DBs it's not much of a problem running the PHPUnit tests, but for Oracle, this takes 5+ hours.
              Hide
              skodak Petr Skoda added a comment -

              Hmm, in general the point is to run all tests to verify there are no regressions introduced elsewhere. I will see what can be done with oracle performance later this week (If I somehow make it work here).

              Show
              skodak Petr Skoda added a comment - Hmm, in general the point is to run all tests to verify there are no regressions introduced elsewhere. I will see what can be done with oracle performance later this week (If I somehow make it work here).
              Hide
              salvetore Michael de Raadt added a comment -

              True, you're right, Petr.

              Thanks, for looking at the performance of the tests.

              Show
              salvetore Michael de Raadt added a comment - True, you're right, Petr. Thanks, for looking at the performance of the tests.
              Hide
              salvetore Michael de Raadt added a comment -

              I've run the PHPUnit tests in SQL Server, MySQL and PostgreSQL. There were a couple of SQL related fails in MySQL and SQL Server, but I don't think they're related.

              I'm starting to run these under Oracle.

              Show
              salvetore Michael de Raadt added a comment - I've run the PHPUnit tests in SQL Server, MySQL and PostgreSQL. There were a couple of SQL related fails in MySQL and SQL Server, but I don't think they're related. I'm starting to run these under Oracle.
              Hide
              salvetore Michael de Raadt added a comment -

              Test result: Success

              Show
              salvetore Michael de Raadt added a comment - Test result: Success
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              UPDATE tracker_issues
                 SET status = 'Closed',
                    comment = 'Thanks!'
              WHEN participants = 'Did a gorgeous work'

              This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12