Moodle
  1. Moodle
  2. MDL-32587

add Eloy's phpunit.xml dist builder to phpunit

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      1/ execute "php admin/tool/phpunit/cli/util.php --buildcomponentconfigs"
      2/ go to some plugin such as /mod/page/ directory and execute "phpunit" - expected execution of all tests for mod_page
      3/ go to some subsystem such as /backup/ directory and execute "phpunit" - expected execution of all tests for backup/restore

      Show
      1/ execute "php admin/tool/phpunit/cli/util.php --buildcomponentconfigs" 2/ go to some plugin such as /mod/page/ directory and execute "phpunit" - expected execution of all tests for mod_page 3/ go to some subsystem such as /backup/ directory and execute "phpunit" - expected execution of all tests for backup/restore
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w18_MDL-32587_m23_phpunitindividual
    • Rank:
      39508

      Activity

      Hide
      Eloy Lafuente (stronk7) added a comment -

      The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

      TIA and ciao

      Show
      Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
      Hide
      Sam Hemelryk added a comment -

      In it goes

      Show
      Sam Hemelryk added a comment - In it goes
      Hide
      Michael de Raadt added a comment -

      Test result: Not successful

      I ran the util script, but no phpunit.xml files were generated in subdirectories. This may be because I'm using Windows. I put some debugging outputs in the script and it looks like the components array is empty before starting the file output. So no files are generated, but no errors are reported. Without debugging this further, I have fail this test for now.

      Show
      Michael de Raadt added a comment - Test result: Not successful I ran the util script, but no phpunit.xml files were generated in subdirectories. This may be because I'm using Windows. I put some debugging outputs in the script and it looks like the components array is empty before starting the file output. So no files are generated, but no errors are reported. Without debugging this further, I have fail this test for now.
      Hide
      Petr Škoda added a comment -

      fix pushed to repo, thanks for discovering this problem!
      to integrators: please merge one more commit

      ciao

      Show
      Petr Škoda added a comment - fix pushed to repo, thanks for discovering this problem! to integrators: please merge one more commit ciao
      Hide
      Dan Poltawski added a comment -

      I've pulled the fix - thanks ready for testing agian

      Show
      Dan Poltawski added a comment - I've pulled the fix - thanks ready for testing agian
      Hide
      Michael de Raadt added a comment -

      Test result: Success!

      The script now generates files.

      I tested this on a number modules and subsystems.

      Show
      Michael de Raadt added a comment - Test result: Success! The script now generates files. I tested this on a number modules and subsystems.
      Hide
      Eloy Lafuente (stronk7) added a comment -
      UPDATE tracker_issues
         SET status = 'Closed',
            comment = 'Thanks!'
      WHEN participants = 'Did a gorgeous work'
      

      This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

      Show
      Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

        People

        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: