Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32605

Missing third parameter for get_string call in calender/delete.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Goto site pages> calendar >new event
      2. create a event of any type. check the box that says "repeated event" and set it to repeat 10 times.
      3. Go back to calendar and select a date that contains one of these events
      4. click the x icon to delete the event
      5. on the resulting page, make sure the string reads something like "This event is part of a repeating event series. You can delete this event only, or all 10 events in the series at once."
      6. Go ahead and delete the event. Make sure it is deleted.
      Show
      Goto site pages> calendar >new event create a event of any type. check the box that says "repeated event" and set it to repeat 10 times. Go back to calendar and select a date that contains one of these events click the x icon to delete the event on the resulting page, make sure the string reads something like "This event is part of a repeating event series. You can delete this event only, or all 10 events in the series at once." Go ahead and delete the event. Make sure it is deleted.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32605-master

      Description

      $repeatspan = '<br /><br /><span>'.get_string('youcandeleteallrepeats', 'calendar').'</span>';

      should be

      $repeatspan = '<br /><br /><span>'.get_string('youcandeleteallrepeats', 'calendar', $event->count_repeats()).'</span>';

      in calendar/delete.php Line 110

      Thanks

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              ankit_frenz Ankit Agarwal
              Peer reviewer:
              Rossiani Wijaya
              Integrator:
              Dan Poltawski
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12