[MDL-32605] Missing third parameter for get_string call in calender/delete.php - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle
Pull Master Branch:
~~MDL-32605~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/MDL-32605-master
Difficulty:
Easy
Testing Instructions:
Hide

Goto site pages> calendar >new event

create a event of any type. check the box that says "repeated event" and set it to repeat 10 times.

Go back to calendar and select a date that contains one of these events

click the x icon to delete the event

on the resulting page, make sure the string reads something like "This event is part of a repeating event series. You can delete this event only, or all 10 events in the series at once."

Go ahead and delete the event. Make sure it is deleted.
Show
Goto site pages> calendar >new event create a event of any type. check the box that says "repeated event" and set it to repeat 10 times. Go back to calendar and select a date that contains one of these events click the x icon to delete the event on the resulting page, make sure the string reads something like "This event is part of a repeating event series. You can delete this event only, or all 10 events in the series at once." Go ahead and delete the event. Make sure it is deleted.

$repeatspan = '<br /><br /><span>'.get_string('youcandeleteallrepeats', 'calendar').'</span>';

should be

$repeatspan = '<br /><br /><span>'.get_string('youcandeleteallrepeats', 'calendar', $event->count_repeats()).'</span>';

in calendar/delete.php Line 110

Thanks

Testing discovered

MDL-31671 Unable to delete all events in a recurring series after the first event from that recurring series had already been deleted.

Participants:: Ankit Agarwal, Dan Poltawski, Jason Fowler, Rossiani Wijaya, Sam Hemelryk

Component watchers:: Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze