Moodle
  1. Moodle
  2. MDL-32610

Update notifications should have a kill switch

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: medium (requires access to the source code)

      1. Put $CFG->disableupdatenotifications = true; into your config.php (there is no corresponding UI setting intentionally)
      2. TEST: Make sure there is no Site administration > Server > Update notifications section available
      3. TEST: Make sure there is no available updates info at the Plugins overview admin page
      4. TEST: Make sure there is no available updates info at the admin Notifications page
      5. Increase the $plugin->version in some of your plugin's version.php file and visit the /admin page
      6. TEST: Make sure there is no available updates info at the Plugins check upgrade page
      7. Execute cron and grap its output
      8. TEST: Make sure there is nothing regarding available updates fetching mentioned in the cron output
      9. Remove the flag from the config.php and ideally make sure that all places mentioned above have the available updates related controls back.

      Show
      Testing difficulty: medium (requires access to the source code) 1. Put $CFG->disableupdatenotifications = true; into your config.php (there is no corresponding UI setting intentionally) 2. TEST: Make sure there is no Site administration > Server > Update notifications section available 3. TEST: Make sure there is no available updates info at the Plugins overview admin page 4. TEST: Make sure there is no available updates info at the admin Notifications page 5. Increase the $plugin->version in some of your plugin's version.php file and visit the /admin page 6. TEST: Make sure there is no available updates info at the Plugins check upgrade page 7. Execute cron and grap its output 8. TEST: Make sure there is nothing regarding available updates fetching mentioned in the cron output 9. Remove the flag from the config.php and ideally make sure that all places mentioned above have the available updates related controls back.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32610-hide-updates
    • Rank:
      39537

      Description

      In a few circumstances (such as completely managed servers, which may have a lot of local modifications) it is desirable to not have the check for updates active.

      Please add a config variable check such as

       if (!empty($CFG->disableupdatenotifications)) {
          return;   // Hide all this functionality from GUI and disable cron checks etc
       }
      

      so it can be defined in config.php

        Issue Links

          Activity

          Martin Dougiamas created issue -
          Martin Dougiamas made changes -
          Field Original Value New Value
          Assignee Rajesh Taneja [ rajeshtaneja ] David Mudrak [ mudrd8mz ]
          Martin Dougiamas made changes -
          Link This issue development required addition/change MDL-20438 [ MDL-20438 ]
          Martin Dougiamas made changes -
          Link This issue has a non-specific relationship to MDL-20438 [ MDL-20438 ]
          Martin Dougiamas made changes -
          Link This issue development required addition/change MDL-20438 [ MDL-20438 ]
          Martin Dougiamas made changes -
          Priority Minor [ 4 ] Blocker [ 1 ]
          Labels partner triaged
          David Mudrak made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          David Mudrak made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/mudrd8mz/moodle/compare/master...MDL-32610-hide-updates
          Pull Master Branch MDL-32610-hide-updates
          Pull from Repository git://github.com/mudrd8mz/moodle.git
          Fix Version/s 2.3 [ 10657 ]
          Testing Instructions Testing difficulty: medium (requires access to the source code)

          1. Put $CFG->disableupdatenotifications = true; into your config.php (there is no corresponding UI setting intentionally)
          2. TEST: Make sure there is no Site administration > Server > Update notifications section available
          3. TEST: Make sure there is no available updates info at the Plugins overview admin page
          4. TEST: Make sure there is no available updates info at the admin Notifications page
          5. Increase the $plugin->version in some of your plugin's version.php file and visit the /admin page
          6. TEST: Make sure there is no available updates info at the Plugins check upgrade page
          7. Execute cron and grap its output
          8. TEST: Make sure there is nothing regarding available updates fetching mentioned in the cron output
          9. Remove the flag from the config.php and ideally make sure that all places mentioned above have the available updates related controls back.
          Petr Škoda made changes -
          Comment [ hmm, maybe you could hide it just with CSS ]
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Currently in integration Yes [ 10041 ]
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester andyjdavis
          Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 19/May/12

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: