[MDL-32611] Fatal error in editcategory.php when users has manager role at category level - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Log in as an admin

Create a new category called "Management test"

Browse to that category and turn on editing if its not already on.

Click the button to add a sub category and check there are no errors on the page.

Create a new user called "manager"

Browse to the management test category and assign the manager user the role of manager

Log in as manager

Browse to the management test category and turn editing on

Click the button to add a sub category and check you don't get any errors.
Show
Log in as an admin Create a new category called "Management test" Browse to that category and turn on editing if its not already on. Click the button to add a sub category and check there are no errors on the page. Create a new user called "manager" Browse to the management test category and assign the manager user the role of manager Log in as manager Browse to the management test category and turn editing on Click the button to add a sub category and check you don't get any errors.
Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Master Branch:
wip-~~MDL-32611~~-m23
Pull Master Diff URL:
https://github.com/samhemelryk/moodle/compare/master...wip-MDL-32611-m23

To reporduce in Moodle 2.2.2+ (Build: 20120412)

as admin 1) create a user USR 2) create a category CAT 3) turn debugging on
assign to previously created user USR the manager role at category level CAT
login as USR
go to the category USR has manager role in
turn editing on
click on "add a sub category"
the following error is displayed: Fatal error: Call to a member function get() on a non-object in ..../editcategory.php on line 139

It appears something related to navigation, as the line is

$PAGE->settingsnav->get('root')->get('courses')->get('coursemgmt')->make_active();

is duplicated by

MDL-34064 /course/editcategory.php can produce a fatal error

Participants:: Andrea Bicciolo, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Michael de Raadt, Ralf Krause, Sam Hemelryk

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias