Moodle
  1. Moodle
  2. MDL-32620

LTI return URL is not getting set correctly

    Details

    • Testing Instructions:
      Hide

      Set up http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php as an external tool in a course (key: 12345, secret: secret).

      Verify the launch_presentation_return_url is set in the "RAW Post Parameters" section.

      There should also be a link that says "Return to tool consumer". Clicking it should take you back to the Moodle course.

      Show
      Set up http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php as an external tool in a course (key: 12345, secret: secret). Verify the launch_presentation_return_url is set in the "RAW Post Parameters" section. There should also be a link that says "Return to tool consumer". Clicking it should take you back to the Moodle course.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      39547

      Description

      In LTI, the LMS sends along the launch_presentation_return_url parameter. This parameter instructs the tool provider where to send the user after they're done using the tool.

      Moodle is not sending the launch_presentation_return_url parameter in most cases due to a coding error.

        Activity

        Hide
        Chris Scribner added a comment -
        Show
        Chris Scribner added a comment - Fix is in branch https://github.com/scriby/moodle/tree/MDL-32620
        Hide
        Chris Scribner added a comment -

        Dan, can you peer review this one as well?

        Show
        Chris Scribner added a comment - Dan, can you peer review this one as well?
        Hide
        Dan Poltawski added a comment -

        Yep (sorry I have a big backlog at the moment but will get to this - thanks)

        Show
        Dan Poltawski added a comment - Yep (sorry I have a big backlog at the moment but will get to this - thanks)
        Hide
        Dan Poltawski added a comment -

        Thanks Chris,

        Again if you could write testing instructions I will submit this for integration.

        I know you didn't change the line here, but FYI the Moodle commenting style should be:

        // Comment after a single space.
        

        (Need a space after the // )

        Show
        Dan Poltawski added a comment - Thanks Chris, Again if you could write testing instructions I will submit this for integration. I know you didn't change the line here, but FYI the Moodle commenting style should be: // Comment after a single space. (Need a space after the // )
        Hide
        Chris Scribner added a comment -

        Testing instructions:

        Set up http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php as an external tool in a course (key: 12345, secret: secret).

        Verify the launch_presentation_return_url is set in the "RAW Post Parameters" section.

        There should also be a link that says "Return to tool consumer". Clicking it should take you back to the Moodle course.

        Show
        Chris Scribner added a comment - Testing instructions: Set up http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php as an external tool in a course (key: 12345, secret: secret). Verify the launch_presentation_return_url is set in the "RAW Post Parameters" section. There should also be a link that says "Return to tool consumer". Clicking it should take you back to the Moodle course.
        Hide
        Dan Poltawski added a comment -

        Sorry Chris, this got lost in my queue. If you could fix up that comment i'm pushing for integration.

        Show
        Dan Poltawski added a comment - Sorry Chris, this got lost in my queue. If you could fix up that comment i'm pushing for integration.
        Hide
        Mark Nielsen added a comment -

        I fixed the space

        Show
        Mark Nielsen added a comment - I fixed the space
        Hide
        Dan Poltawski added a comment -

        Thanks Mark

        Show
        Dan Poltawski added a comment - Thanks Mark
        Hide
        Damyon Wiese added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        Thanks!

        Show
        Damyon Wiese added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        LOL, it took me a bunch of minutes to realize you were moving the code out from the "if", blindly me!

        I'm adding one commit on top fixing:

        • incorrect whitespace.
        • final dot at the end of inline comments.

        And this will be spread to all supported stables.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - LOL, it took me a bunch of minutes to realize you were moving the code out from the "if", blindly me! I'm adding one commit on top fixing: incorrect whitespace. final dot at the end of inline comments. And this will be spread to all supported stables. Ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
        Hide
        Rajesh Taneja added a comment -

        Thanks for fixing this Chris,

        Works as described.

        Show
        Rajesh Taneja added a comment - Thanks for fixing this Chris, Works as described.
        Hide
        Damyon Wiese added a comment -

        Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

        Regards, Damyon

        Show
        Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: