Moodle
  1. Moodle
  2. MDL-32621

Database approve icon missing 'title' field

    Details

    • Testing Instructions:
      Hide

      These testing instructions are nearly identical to MDL-19391. If you want to save yourself time, test them together

      As a teacher

      • Create a new database activity
        • Set the 'Require Approval' setting to 'Yes'
      • Create a field
      • Generate the default templates

      As a Student

      • Navigate to the database activity
      • Create a new record in the database

      As a teacher

      • Navigate to the database
      • Locate the newly created record awaiting approval
      • Mouse over the approval icon
        • Confirm that the text 'Approve' button is shown
      Show
      These testing instructions are nearly identical to MDL-19391 . If you want to save yourself time, test them together As a teacher Create a new database activity Set the 'Require Approval' setting to 'Yes' Create a field Generate the default templates As a Student Navigate to the database activity Create a new record in the database As a teacher Navigate to the database Locate the newly created record awaiting approval Mouse over the approval icon Confirm that the text 'Approve' button is shown
    • Affected Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32621-master-1
    • Rank:
      39548

      Description

      The approve icon's anchor on the database activity is missing the title attribute.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          This commit is based upon MDL-19391 as the commits are on the same line.

          This should cherry-pick to all stable branches.

          Show
          Andrew Nicols added a comment - This commit is based upon MDL-19391 as the commits are on the same line. This should cherry-pick to all stable branches.
          Hide
          Dan Poltawski added a comment -

          Looks fine, but for accessibility maybe we should consider this: MDL-31976

          Show
          Dan Poltawski added a comment - Looks fine, but for accessibility maybe we should consider this: MDL-31976
          Hide
          Andrew Nicols added a comment -

          This isn't the right fix for accessibility. Closing.

          Show
          Andrew Nicols added a comment - This isn't the right fix for accessibility. Closing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: