Moodle
  1. Moodle
  2. MDL-32633

Setting the maximum grade to zero appears to permanently remove quiz from gradebook

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.2.3, 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a quiz and add some questions.
      2. Make sure the quiz appears in the grade-book.
      3. On the quiz editing page, change Maximum grade to 0. Make sure the grade item disappears from the gradebook.
      4. In the quiz settings, change the grading method, e.g. from Highest grade to Last attempt. Make sure the quiz still does not appear in the gradebook.
      5. Change the quiz Maximum grade back to something non-zero (e.g. 10).
      6. Make sure the quiz has re-appeared in the gradebook.

      7. Now make one or more quiz attempts as a student.
      8. Then repeat steps 1. to 6., but in addition to the other checks, make sure the student's grades are correct when they reappear.

      Show
      1. Create a quiz and add some questions. 2. Make sure the quiz appears in the grade-book. 3. On the quiz editing page, change Maximum grade to 0. Make sure the grade item disappears from the gradebook. 4. In the quiz settings, change the grading method, e.g. from Highest grade to Last attempt. Make sure the quiz still does not appear in the gradebook. 5. Change the quiz Maximum grade back to something non-zero (e.g. 10). 6. Make sure the quiz has re-appeared in the gradebook. 7. Now make one or more quiz attempts as a student. 8. Then repeat steps 1. to 6., but in addition to the other checks, make sure the student's grades are correct when they reappear.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      39563

      Description

      If while editing a quiz an instructor sets the maximum grade to zero, the quiz is permanently removed from the gradebook. Should the instructor then attempt to reset the maximum grade to a non-zero setting, the quiz will not restored to the gradebook. If students then take the quiz, the instructor is able to manually peruse the quiz grades, but he/she is unable to restore the quiz as an item to be included in the gradebook.

      This bug is easy to replicate by creating a test quiz, verifying that the test quiz was included as a gradebook item, and then editing the quiz and setting the maximum grade to zero. The quiz will no longer be in the gradebook, nor will it be restored to the gradebook after subsequently setting the maximum grade to it's original (non-zero) value.

        Activity

        Hide
        Tim Hunt added a comment -

        As a work-around, if you change the Grading method in the quiz settings (e.g. from Highest grade -> First attempt) then this fixes it. Now I need to work out why that works, and Edit quiz does not.

        Show
        Tim Hunt added a comment - As a work-around, if you change the Grading method in the quiz settings (e.g. from Highest grade -> First attempt) then this fixes it. Now I need to work out why that works, and Edit quiz does not.
        Hide
        Tim Hunt added a comment -

        I think I've got it.

        Show
        Tim Hunt added a comment - I think I've got it.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        integrated and ready for testing.

        Show
        Aparup Banerjee added a comment - integrated and ready for testing.
        Hide
        Rossiani Wijaya added a comment -

        Hi Tim,

        I have question with step 4, final grade is the same as 'last attempt' correct?

        Show
        Rossiani Wijaya added a comment - Hi Tim, I have question with step 4, final grade is the same as 'last attempt' correct?
        Hide
        Tim Hunt added a comment -

        Sorry yes. You are right. I just fixed it.

        Show
        Tim Hunt added a comment - Sorry yes. You are right. I just fixed it.
        Hide
        Rossiani Wijaya added a comment -

        Great! Thanks for updating the test instruction Tim.

        This is working great.

        Test passed.

        Show
        Rossiani Wijaya added a comment - Great! Thanks for updating the test instruction Tim. This is working great. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        U P S T R E A M I Z E D !

        Many thanks for the hard work, closing this as fixed.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: