Moodle
  1. Moodle
  2. MDL-32634

Items rated as 'mostly connected knowing' shown rated as 'separate and connected'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: Ratings
    • Labels:
      None
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      39565

      Description

      If an item is rated as 'mostly connected knowing' in any module, it is shown as 'separate and connected' in the ratings pop up.

      This appears to because of some odd code in /rating/index.php.

      On line 65 $scalemenu is declared and element 3 is 'mostly connected knowing' and this is the highest numbered element (there's no 0). 2 is 'separate and connected'.
      On line 106 $maxrating = count($scalemenu) - 1; (i.e. this would be 2).
      On line 121 The $rating->rating is 3 initially, but is changed to $maxrating if the number is higher than $maxrating.

      This causes 'separate and connected' to be displayed in error.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Hi, Anthony.

          I wasn't able to replicate your findings. It may be that this issue has been resolved by recent work in MDL-30955, or perhaps I'm not replicating the problem in the same way you are.

          I'm not sure if you are able to, but you might want to grab the latest weekly code and see if this problem persists. If it does, could you list a set of specific replication steps?

          Show
          Michael de Raadt added a comment - Hi, Anthony. I wasn't able to replicate your findings. It may be that this issue has been resolved by recent work in MDL-30955 , or perhaps I'm not replicating the problem in the same way you are. I'm not sure if you are able to, but you might want to grab the latest weekly code and see if this problem persists. If it does, could you list a set of specific replication steps?
          Hide
          Anthony Forth added a comment -

          This was fixed by MDL-30955.

          Show
          Anthony Forth added a comment - This was fixed by MDL-30955 .

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: