Moodle
  1. Moodle
  2. MDL-32645

Fix Oracle enrol_database unit tests

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Enrolments
    • Labels:

      Description

      the problem was discovered by the new adodb_test.php in master

      This probably prevents syncing of enrolments with oracle databases...

        Gliffy Diagrams

          Issue Links

            Activity

            Petr Skoda created issue -
            Petr Skoda made changes -
            Field Original Value New Value
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            Petr Skoda made changes -
            Link This issue discovered while testing MDL-32574 [ MDL-32574 ]
            Petr Skoda made changes -
            Description the problem was discovered by the new adodb_test.php in master the problem was discovered by the new adodb_test.php in master

            This probably prevents syncing of enrolments with oracle databases...
            Show
            Eloy Lafuente (stronk7) added a comment - reference: http://tracker.moodle.org/browse/MDL-32574?focusedCommentId=154371&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-154371
            Petr Skoda made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            Petr Skoda made changes -
            Fix Version/s 2.3 [ 10657 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Affects Version/s 2.3 [ 10657 ]
            Affects Version/s 2.2 [ 10656 ]
            Petr Skoda made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w19_MDL-32645_m23_oraenrol
            Pull Master Branch w19_MDL-32645_m23_oraenrol
            Pull from Repository git://github.com/skodak/moodle.git
            Testing Instructions run phpunit tests for oracle
            Petr Skoda made changes -
            Testing Instructions run phpunit tests for oracle run phpunit tests for oracle
            no failure expected in enrol_database any more
            Dan Poltawski made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator poltawski
            Currently in integration Yes [ 10041 ]
            Hide
            Dan Poltawski added a comment -

            Thanks, i've integrated this now.

            Show
            Dan Poltawski added a comment - Thanks, i've integrated this now.
            Dan Poltawski made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Hide
            Dan Poltawski added a comment -

            Updating title since this appears to only be an issue in the unit tests.

            Show
            Dan Poltawski added a comment - Updating title since this appears to only be an issue in the unit tests.
            Dan Poltawski made changes -
            Summary review and fix Oracle uppercase indexed resultsets in enrol_database Fix Oracle enrol_database unit tests
            Hide
            Dan Poltawski added a comment -

            Assigning myself as tester as i've not done an oracle unit test run yet.

            Show
            Dan Poltawski added a comment - Assigning myself as tester as i've not done an oracle unit test run yet.
            Dan Poltawski made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester poltawski
            Hide
            Dan Poltawski added a comment -

            Hmm, just running this one test takes 276MB of memory!

            Show
            Dan Poltawski added a comment - Hmm, just running this one test takes 276MB of memory!
            Hide
            Dan Poltawski added a comment -

            It worked, thanks!

            Show
            Dan Poltawski added a comment - It worked, thanks!
            Dan Poltawski made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

            Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao
            Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 11/May/12

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: