Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32649

Ratings pop up sort links broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.2, 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Ratings
    • Labels:
    • Testing Instructions:
      Hide

      Create a forum and enable ratings in the forum settings. Set it to average with a max grade of 5 or similar.

      I'd recommend posting as a student then rating that post as admin and as teacher so you have 2 ratings to sort. Posting as student then having the teacher and admin rate avoids having to alter the default capabilities for this test.

      Log in as admin and next to the rating drop down is a number that is the aggregate of all ratings the student has received.

      Click it and a popup will appear that lists the submitted ratings.

      Click the column headings (name, rating, time) and the ratings should be sorted. Note that it is not currently possible to reverse the sort order so clicking a single heading multiple times doesn't do anything. You'll only notice a change when you click a different column heading. Even then the order won't change if they are already in the correct order.

      Show
      Create a forum and enable ratings in the forum settings. Set it to average with a max grade of 5 or similar. I'd recommend posting as a student then rating that post as admin and as teacher so you have 2 ratings to sort. Posting as student then having the teacher and admin rate avoids having to alter the default capabilities for this test. Log in as admin and next to the rating drop down is a number that is the aggregate of all ratings the student has received. Click it and a popup will appear that lists the submitted ratings. Click the column headings (name, rating, time) and the ratings should be sorted. Note that it is not currently possible to reverse the sort order so clicking a single heading multiple times doesn't do anything. You'll only notice a change when you click a different column heading. Even then the order won't change if they are already in the correct order.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-32649_ratings_sort

      Description

      When viewing items in the ratings pop-up, clicking on 'name', 'rating' or 'time' to change the sort order takes you instead to a different screen. Looks like a minor error on line 87 of rating/index.php (but shouldn't it also have 'component' as a param?).

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12