Moodle

Renaming a table does not facilitate the renaming of the associated comment.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 2.2.2
  • Fix Version/s: None
  • Component/s: Database SQL/XMLDB
  • Labels:
  • Testing Instructions:
    Hide

    Pick any block / module / course format with a 'db' folder, change the table name and comment in the 'install.xml' file and attempt to do the same action in the 'upgrade.php' file.

    Observe the table description in your chosen database viewer.

    Show
    Pick any block / module / course format with a 'db' folder, change the table name and comment in the 'install.xml' file and attempt to do the same action in the 'upgrade.php' file. Observe the table description in your chosen database viewer.
  • Affected Branches:
    MOODLE_22_STABLE

Description

When you are writing update code in a module/block/course format's 'upgrade.php' and wish to rename a table you can call the function 'rename_table' in '/lib/ddl/database_manager.php', however you cannot rename the associated comment on the table that was defined in the 'install.xml' file. So although you can alter the comment in 'install.xml' for new installations, upgrading installations have the wrong comment in their database to explain what the table is for.

I have stated that this is for 2.2.2 but could be elsewhere too.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

Hello, yes, this is a known problem since 1.7 at least. Thanks for the report.

Show
Petr Škoda added a comment - Hello, yes, this is a known problem since 1.7 at least. Thanks for the report.
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d.

TW9vZGxlDQo=

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

This is being done as part of a bulk annual clean-up of issues.

If you still believe this is an issue in supported versions, please create a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: