Moodle
  1. Moodle
  2. MDL-32657

Section dragdrop: make possible to define elements swapping in the course format

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      One way to test if it works, is to install one of non-core formats and make sure that neither section nor resource drag-drop works for it.
      The simpler way, is to comment out:

          // Include course format js module
          //$PAGE->requires->js('/course/format/topics/format.js');
      

      at the bottom of course/format/topics/format.php and ensure that drag-drop stopped working for topics format, but still works for weeks.

      Show
      One way to test if it works, is to install one of non-core formats and make sure that neither section nor resource drag-drop works for it. The simpler way, is to comment out: // Include course format js module //$PAGE->requires->js('/course/format/topics/format.js'); at the bottom of course/format/topics/format.php and ensure that drag-drop stopped working for topics format, but still works for weeks.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32657-master-1
    • Rank:
      39597

      Description

      As discussed in MDL-31052, it should be possible to define on the format level which elements should be modified as a result of nodes swapping. The idea is to have a yui module or js file per format, which will have the required functions.

        Issue Links

          Activity

          Ruslan Kabalin created issue -
          Ruslan Kabalin made changes -
          Field Original Value New Value
          Link This issue is blocked by MDL-31052 [ MDL-31052 ]
          Ruslan Kabalin made changes -
          Andrew Nicols made changes -
          Assignee moodle.com [ moodle.com ] Andrew Nicols [ dobedobedoh ]
          Andrew Nicols made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Assignee Andrew Nicols [ dobedobedoh ] Ruslan Kabalin [ kabalin ]
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
          Peer reviewer poltawski
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Michael de Raadt made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Fix Version/s DEV backlog [ 10464 ]
          Labels triaged
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s DEV backlog [ 10464 ]
          Ruslan Kabalin made changes -
          Testing Instructions One way to test if it works, is to install one of non-core formats and make sure that neither section nor resource drag-drop works for it.
          The simpler way, is to comment out:
          {code}
              // Include course format js module
              //$PAGE->requires->js('/course/format/topics/format.js');
          {code}
          at the bottom of course/format/topics/format.php and ensure that drag-drop stopped working for topics format, but still works for weeks.
          Michael de Raadt made changes -
          Tester rwijaya
          Rossiani Wijaya made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Rossiani Wijaya made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Ruslan Kabalin made changes -
          Link This issue has been marked as being related by MDL-32744 [ MDL-32744 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 04/May/12
          Gareth J Barnard made changes -
          Link This issue has a non-specific relationship to CONTRIB-3652 [ CONTRIB-3652 ]

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: