Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32665

New user message alert popup appears in chat window frames.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Chat, Messages
    • Labels:
    • Testing Instructions:
      Hide

      You'll need a chat activity, 2 users and 2 browsers ie Firefox and chrome.

      As user 1 check that you're messaging preferences are to receive personal message notifications (online and offline) via popup.

      Go to a chat activity. Its the page with "click here to enter chat now" etc.

      Go your other browser, log in as another user and send the first user a personal message.

      Return to the first user.

      Click "click here to enter now". A chat window will pop up. No messaging notification should be displayed. Close the chat window.

      Click "Use more accessible interface". The non-ajax chat window will pop up. No messaging notification should be displayed. Close the chat window.

      Refresh the chat activity (or return to the course page). You should now get a messaging popup notification in the bottom right of the screen.

      Show
      You'll need a chat activity, 2 users and 2 browsers ie Firefox and chrome. As user 1 check that you're messaging preferences are to receive personal message notifications (online and offline) via popup. Go to a chat activity. Its the page with "click here to enter chat now" etc. Go your other browser, log in as another user and send the first user a personal message. Return to the first user. Click "click here to enter now". A chat window will pop up. No messaging notification should be displayed. Close the chat window. Click "Use more accessible interface". The non-ajax chat window will pop up. No messaging notification should be displayed. Close the chat window. Refresh the chat activity (or return to the course page). You should now get a messaging popup notification in the bottom right of the screen.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-32665_chat_popup

      Description

      When an user has unread messages and opens a chat activity the alert popup notification appears in both frames of the chat window.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this.

            I've put that on the backlog.

            In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.
            Hide
            andyjdavis Andrew Davis added a comment -

            As is traditional I have opened a new bug while fixing this one. MDL-34367

            Show
            andyjdavis Andrew Davis added a comment - As is traditional I have opened a new bug while fixing this one. MDL-34367
            Hide
            andyjdavis Andrew Davis added a comment -

            Added testing instructions and a branch with a possible fix. Putting this up for peer review.

            Show
            andyjdavis Andrew Davis added a comment - Added testing instructions and a branch with a possible fix. Putting this up for peer review.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hehe that was easy, changes look perfect Andrew, feel free to put up when ready.

            Show
            samhemelryk Sam Hemelryk added a comment - Hehe that was easy, changes look perfect Andrew, feel free to put up when ready.
            Hide
            andyjdavis Andrew Davis added a comment -

            Adding branches and putting up for integration.

            Show
            andyjdavis Andrew Davis added a comment - Adding branches and putting up for integration.
            Hide
            nebgor Aparup Banerjee added a comment -

            looks good to me too!

            Show
            nebgor Aparup Banerjee added a comment - looks good to me too!
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks Andrew, thats integrated into 22, 23 and master.

            Show
            nebgor Aparup Banerjee added a comment - Thanks Andrew, thats integrated into 22, 23 and master.
            Hide
            fred Frédéric Massart added a comment -

            Test successful on 2.2, 2.3 and master! Cheers!

            Show
            fred Frédéric Massart added a comment - Test successful on 2.2, 2.3 and master! Cheers!
            Hide
            nebgor Aparup Banerjee added a comment -

            yay, it works!

            This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

            Thank you all for taking the time to get us here.

            cheers!

            Show
            nebgor Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12