Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32670

Chat module is missing $PAGE->set_heading

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Critical
          • Resolution: Fixed
          • Affects Version/s: 2.2.2
          • Fix Version/s: 2.1.6, 2.2.3
          • Component/s: Chat
          • Labels:

            Description

            The chat module does not call $PAGE->set_heading(), so for our theme when viewing the "index.php" file for the chat module it is missing the header/nav bar.

            This also happens on demo.moodle.net. Notice the difference for a properly behavior module like resource: http://demo.moodle.net/mod/resource/index.php?id=5

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is duplicated by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28004 Header is not visible while viewing past chat sessions

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    rex Rex Lorenzo added a comment -

                    Working on submitting a patch. Following Tim Hunt's guide at http://tjhunt.blogspot.com/2012/03/fixing-bug-in-moodle-core-mechanics.html

                    Show
                    rex Rex Lorenzo added a comment - Working on submitting a patch. Following Tim Hunt's guide at http://tjhunt.blogspot.com/2012/03/fixing-bug-in-moodle-core-mechanics.html
                    Hide
                    Permalink
                    rex Rex Lorenzo added a comment -

                    Added patch

                    Show
                    rex Rex Lorenzo added a comment - Added patch
                    Hide
                    Permalink
                    salvetore Michael de Raadt added a comment -

                    Thanks for spotting that and providing a solution.

                    Show
                    salvetore Michael de Raadt added a comment - Thanks for spotting that and providing a solution.
                    Hide
                    Permalink
                    rex Rex Lorenzo added a comment -

                    Also found out that report.php was also missing the set_heading call. Added that as well.

                    Show
                    rex Rex Lorenzo added a comment - Also found out that report.php was also missing the set_heading call. Added that as well.
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    Hi Rex,

                    This looks good thanks for the patch! Submitting for integration

                    Show
                    poltawski Dan Poltawski added a comment - Hi Rex, This looks good thanks for the patch! Submitting for integration
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks guys, this has been integrated now

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Tested during integration review and passed

                    Show
                    samhemelryk Sam Hemelryk added a comment - Tested during integration review and passed
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

                    Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

                    Closing, ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        0 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/May/12