Moodle
  1. Moodle
  2. MDL-32670

Chat module is missing $PAGE->set_heading

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 2.2.2
        • Fix Version/s: 2.1.6, 2.2.3
        • Component/s: Chat
        • Labels:

          Description

          The chat module does not call $PAGE->set_heading(), so for our theme when viewing the "index.php" file for the chat module it is missing the header/nav bar.

          This also happens on demo.moodle.net. Notice the difference for a properly behavior module like resource: http://demo.moodle.net/mod/resource/index.php?id=5

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Rex Lorenzo added a comment -

              Working on submitting a patch. Following Tim Hunt's guide at http://tjhunt.blogspot.com/2012/03/fixing-bug-in-moodle-core-mechanics.html

              Show
              Rex Lorenzo added a comment - Working on submitting a patch. Following Tim Hunt's guide at http://tjhunt.blogspot.com/2012/03/fixing-bug-in-moodle-core-mechanics.html
              Hide
              Permalink
              Rex Lorenzo added a comment -

              Added patch

              Show
              Rex Lorenzo added a comment - Added patch
              Hide
              Permalink
              Michael de Raadt added a comment -

              Thanks for spotting that and providing a solution.

              Show
              Michael de Raadt added a comment - Thanks for spotting that and providing a solution.
              Hide
              Permalink
              Rex Lorenzo added a comment -

              Also found out that report.php was also missing the set_heading call. Added that as well.

              Show
              Rex Lorenzo added a comment - Also found out that report.php was also missing the set_heading call. Added that as well.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Hi Rex,

              This looks good thanks for the patch! Submitting for integration

              Show
              Dan Poltawski added a comment - Hi Rex, This looks good thanks for the patch! Submitting for integration
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks guys, this has been integrated now

              Show
              Sam Hemelryk added a comment - Thanks guys, this has been integrated now
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Tested during integration review and passed

              Show
              Sam Hemelryk added a comment - Tested during integration review and passed
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

              Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

              Closing, ciao

              Show
              Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: