Moodle
  1. Moodle
  2. MDL-32676

use cached combo loading for yui3 bootstrapping

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:

      Description

      at the moment it is always loaded as:

       $code .= '<script type="text/javascript" src="'.$this->yui3loader->base.'yui/yui-min.js"></script>';

      the problem is it is not cached properly in browser.

      Safari says: The following resources are missing a cache expiration. Resources that do not specify an expiration may not be cached by browsers.

        Gliffy Diagrams

          Activity

          Hide
          Petr Skoda added a comment -

          This could reduce JS init time in some cases.

          Show
          Petr Skoda added a comment - This could reduce JS init time in some cases.
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
          Hide
          Michael de Raadt added a comment -

          Note for tester: These two settings are site settings. Search for YUI in the admin block.

          Show
          Michael de Raadt added a comment - Note for tester: These two settings are site settings. Search for YUI in the admin block.
          Hide
          Adrian Greeve added a comment -

          Tested with yui combo loading enabled and disabled, and then same again with external yui libraries. No problems encountered.
          Thanks.

          Show
          Adrian Greeve added a comment - Tested with yui combo loading enabled and disabled, and then same again with external yui libraries. No problems encountered. Thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          UPDATE tracker_issues
             SET status = 'Closed',
                comment = 'Thanks!'
          WHEN participants = 'Did a gorgeous work'
          

          This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          Show
          Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: