Details

    • Testing Instructions:
      Hide

      1/ Set coursedisplay to separate sections per page mode
      2/ Click into a course section
      3/ Turn editting on
      4/ Verify that the drag/drop section isn't displayed
      5/ Go to the main course index page and verify that the drag/drop section controls are displayed

      (basically course ajax move icons should match the non-ajax move icons)

      Show
      1/ Set coursedisplay to separate sections per page mode 2/ Click into a course section 3/ Turn editting on 4/ Verify that the drag/drop section isn't displayed 5/ Go to the main course index page and verify that the drag/drop section controls are displayed (basically course ajax move icons should match the non-ajax move icons)
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32681-master-2
    • Rank:
      39632

      Description

      The changes in MDL-32508 are going to introduce a single section page which doesn't make sense to allow sections to be moved (and the non-ajax move icons are not present).

      We need the JS to avoid making move icons too.

      Not sure on the best way to achieve it - you could simply only show the move handle when the icons are present.

        Activity

        Hide
        Dan Poltawski added a comment -

        Andrew/Ruslan - for your consideration

        Checkout MDL-32508-wip from my repo to see the problem

        Show
        Dan Poltawski added a comment - Andrew/Ruslan - for your consideration Checkout MDL-32508 -wip from my repo to see the problem
        Hide
        Andrew Nicols added a comment -

        Coincidentally, I was just discussing this with Ruslan and we were putting a suitable fix together before seeing this bug!

        This change also helps the case of third-party course formats which don't (yet) have the classes for moveup and movedown. This will ensure that users aren't presented with both the drag/drop icon and the moveup/movedown icons at the same time.

        Show
        Andrew Nicols added a comment - Coincidentally, I was just discussing this with Ruslan and we were putting a suitable fix together before seeing this bug! This change also helps the case of third-party course formats which don't (yet) have the classes for moveup and movedown. This will ensure that users aren't presented with both the drag/drop icon and the moveup/movedown icons at the same time.
        Hide
        Dan Poltawski added a comment -

        Looks good and works to fix that issue

        Show
        Dan Poltawski added a comment - Looks good and works to fix that issue
        Hide
        Ruslan Kabalin added a comment -

        Spotted a minor issue, pushed updated branch.

        Show
        Ruslan Kabalin added a comment - Spotted a minor issue, pushed updated branch.
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, a nice simple improvement. This has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks guys, a nice simple improvement. This has been integrated now.
        Hide
        Ankit Agarwal added a comment -

        Working as expected!
        Thanks

        Show
        Ankit Agarwal added a comment - Working as expected! Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

        Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: