Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32688

Guest access to My Moodle fails on Fatal error and results in a blank page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      // Test guest access

      With:

      • Security -> Site policies: 'Force users to login' enabled.
      • Users -> Permissions -> User policies: 'Auto-login guests' enabled.
      • Appearance -> Navigation: Default home page for users = site/my moodle/user preference
      1. Logged in as guest go to My Moodle (e.g. by direct url http://your-moodle-domain.com/my).
      2. Expected: My Moodle page shows system default, no editing.
      Show
      // Test guest access With: Security -> Site policies: 'Force users to login' enabled. Users -> Permissions -> User policies: 'Auto-login guests' enabled. Appearance -> Navigation: Default home page for users = site/my moodle/user preference Logged in as guest go to My Moodle (e.g. by direct url http://your-moodle-domain.com/my ). Expected: My Moodle page shows system default, no editing.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Fatal error: Call to a member function add() on a non-object in .../my/index.php on line 88, on guest access to My Moodle.

      Line 88 is:

              $PAGE->settingsnav->get('usercurrentsettings')->add(get_string('makethismyhome'), new moodle_url('/my/', array('setdefaulthome'=>true)), navigation_node::TYPE_SETTING);

      Probably the easiest way to reproduce is to try a direct access to my moodle by url (http://<your-moodle-domain>/my) when logged out.

      This bug is perhaps more annoying to logged in users whose session times out when they are on my moodle, to the effect that when they refresh the page they get the blank instead of login page.

        Attachments

        1. mdl-32688-admin-setting.png
          22 kB
          Itamar Tzadok
        2. mdl-32688-make-default-home.png
          15 kB
          Itamar Tzadok

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12