Moodle
  1. Moodle
  2. MDL-32693

Add functions to a service has a bad url

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Log in as admin
      Navigate to External services (Settings -> Site administration -> Plugins -> web services -> External services)
      Add new external service and save
      Click on functions and then click on "Add functions"
      Try adding some functions and see you don't see any error.

      Show
      Log in as admin Navigate to External services (Settings -> Site administration -> Plugins -> web services -> External services) Add new external service and save Click on functions and then click on "Add functions" Try adding some functions and see you don't see any error.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
    • Rank:
      39648

      Description

      When adding functions to a web service client I got redirected to a non-existant page

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Jerome,

          Please could you peer review this..

          Show
          Dan Poltawski added a comment - Hi Jerome, Please could you peer review this..
          Hide
          Jérôme Mouneyrac added a comment -

          It's a bit of a tangential decision: +1

          Show
          Jérôme Mouneyrac added a comment - It's a bit of a tangential decision: +1
          Hide
          Jérôme Mouneyrac added a comment -

          cherry-pick on 2.1/2.2 too, I checked it's in these branch too. Thanks for catching it Dan.

          Show
          Jérôme Mouneyrac added a comment - cherry-pick on 2.1/2.2 too, I checked it's in these branch too. Thanks for catching it Dan.
          Hide
          Dan Poltawski added a comment -

          Shamelessly stolen testing instructions from linked issue.

          Show
          Dan Poltawski added a comment - Shamelessly stolen testing instructions from linked issue.
          Hide
          Dan Poltawski added a comment -

          (sorry for missing them before)

          Show
          Dan Poltawski added a comment - (sorry for missing them before)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21, 22 & master). And passed. Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master). And passed. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -
          UPDATE tracker_issues
             SET status = 'Closed',
                comment = 'Thanks!'
          WHEN participants = 'Did a gorgeous work'
          

          This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          Show
          Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: