Moodle
  1. Moodle
  2. MDL-32697

improve oracle and mysql phpunit performance

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Unit tests
    • Labels:
    • Rank:
      39652

      Description

      we have to get it under 1 hour, at present it runs 3-5 hours which it too much

        Activity

        Hide
        Petr Škoda added a comment -

        While waiting for Oracle tests I decided to improve the mysql perf too a bit...

        Show
        Petr Škoda added a comment - While waiting for Oracle tests I decided to improve the mysql perf too a bit...
        Hide
        Petr Škoda added a comment -

        I keep getting a few errors from Oracle tests, but I guess it is my borked install...

        Show
        Petr Škoda added a comment - I keep getting a few errors from Oracle tests, but I guess it is my borked install...
        Hide
        Michael de Raadt added a comment -

        This would be good. Oracle tests are a pain.

        I haven't had any speed issues with SQL Server running natively.

        Show
        Michael de Raadt added a comment - This would be good. Oracle tests are a pain. I haven't had any speed issues with SQL Server running natively.
        Hide
        Eloy Lafuente (stronk7) added a comment - - edited

        MySQL: Time: 02:16, Memory: 251.00Mb - OK (1163 tests, 21047 assertions)
        PostgreSQL: Time: 01:42, Memory: 246.25Mb - OK (1163 tests, 21047 assertions)
        MSSQL: Time: 03:42, Memory: 251.25Mb - FAILURES! Tests: 1163, Assertions: 21004, Failures: 1, Errors: 2.
        Oracle: Time: 41:55, Memory: 248.25Mb - FAILURES!
        Tests: 1163, Assertions: 21038, Failures: 1, Errors: 1.

        MSSQL failures are under control: The recordset out of bounds ones + binary comparison.
        Oracle failure is under control too: The non-ANSI concat and the recently introduced "core_adodb_testcase::test_read_table" => Undefined index: id

        Oracle went down from 3.5h (3 weeks ago) to "just" 40 mins (running into slow VM) so yay!

        So I'm integrating and test-passing this. Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - - edited MySQL: Time: 02:16, Memory: 251.00Mb - OK (1163 tests, 21047 assertions) PostgreSQL: Time: 01:42, Memory: 246.25Mb - OK (1163 tests, 21047 assertions) MSSQL: Time: 03:42, Memory: 251.25Mb - FAILURES! Tests: 1163, Assertions: 21004, Failures: 1, Errors: 2. Oracle: Time: 41:55, Memory: 248.25Mb - FAILURES! Tests: 1163, Assertions: 21038, Failures: 1, Errors: 1. MSSQL failures are under control: The recordset out of bounds ones + binary comparison. Oracle failure is under control too: The non-ANSI concat and the recently introduced "core_adodb_testcase::test_read_table" => Undefined index: id Oracle went down from 3.5h (3 weeks ago) to "just" 40 mins (running into slow VM) so yay! So I'm integrating and test-passing this. Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -
        UPDATE tracker_issues
           SET status = 'Closed',
              comment = 'Thanks!'
        WHEN participants = 'Did a gorgeous work'
        

        This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

        Show
        Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: