Moodle
  1. Moodle
  2. MDL-32709

Feature request: move the Book module from contrib to the Moodle core

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Book, General
    • Labels:
      None
    • Testing Instructions:
      Hide

      As far as this is going to be covered by complete QA tests (see MDLTEST-151), only basic install/usage testing is required here:

      1) Install / upgrade to current version of Moodle.
      2) Book and book tools are shown as standard plugins. Verify no error happens.
      3) In one course, add one book resource type
      4) Add some chapters and subchapters, with some image, play with the up, down, edit, delete, show, add button in edit mode. Verify nothing seems broken.
      5) Duplicate the book. Verify the copy looks like the original (chapters and images).

      That is. Ciao

      Show
      As far as this is going to be covered by complete QA tests (see MDLTEST-151 ), only basic install/usage testing is required here: 1) Install / upgrade to current version of Moodle. 2) Book and book tools are shown as standard plugins. Verify no error happens. 3) In one course, add one book resource type 4) Add some chapters and subchapters, with some image, play with the up, down, edit, delete, show, add button in edit mode. Verify nothing seems broken. 5) Duplicate the book. Verify the copy looks like the original (chapters and images). That is. Ciao
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      21403

      Description

      This request comes up from time to time, so I added a tracker issue for it for people to vote for.

        Issue Links

          Activity

          Hide
          Hannes Gehring added a comment -

          We use Moodle 1.8.3+ and realized, that, if we restored a course manually, the whole course was restored, except the book. So I concluded, that maybe book is not compatible with Moodle 1.8.3, and if it woul be in the core, one would test it an adapt it to the actual version.

          Show
          Hannes Gehring added a comment - We use Moodle 1.8.3+ and realized, that, if we restored a course manually, the whole course was restored, except the book. So I concluded, that maybe book is not compatible with Moodle 1.8.3, and if it woul be in the core, one would test it an adapt it to the actual version.
          Hide
          Derek Chirnside added a comment -

          I think the book is a hidden gem.
          It adds a certain power to centralising content with nice navigation.
          I do not think maintenance over time if it was in the core is a big issue.

          Show
          Derek Chirnside added a comment - I think the book is a hidden gem. It adds a certain power to centralising content with nice navigation. I do not think maintenance over time if it was in the core is a big issue.
          Hide
          Anthony Borrow added a comment -

          Petr - Given the number of votes (currently the most popular CONTRIB issue), might we consider adding the Book module to 2.1? If so, I can move this to a MDL issue. Peace - Anthony

          Show
          Anthony Borrow added a comment - Petr - Given the number of votes (currently the most popular CONTRIB issue), might we consider adding the Book module to 2.1? If so, I can move this to a MDL issue. Peace - Anthony
          Hide
          Myles Carrick added a comment -

          I love Book module, and my current institution is intending to use it extensively... but if the UI allowed such a thing I'd vote against this idea. Perhaps the module should be packaged in core for zip downloads etc... but for managing stuff in Git it's a LOT easier when modules like this are maintained in separate modules.

          Show
          Myles Carrick added a comment - I love Book module, and my current institution is intending to use it extensively... but if the UI allowed such a thing I'd vote against this idea. Perhaps the module should be packaged in core for zip downloads etc... but for managing stuff in Git it's a LOT easier when modules like this are maintained in separate modules.
          Hide
          Brent Lee added a comment -

          I strongly support this request, and would be happy to deploy any test scenarios on my instances throughout British Columbia. I know I can say that at least 10 of my clients would love to see the book move into the core of Moodle.

          Show
          Brent Lee added a comment - I strongly support this request, and would be happy to deploy any test scenarios on my instances throughout British Columbia. I know I can say that at least 10 of my clients would love to see the book move into the core of Moodle.
          Hide
          Mary Parke added a comment -

          I know of MANY institutions that would also love to see this in core. It's simple, elegant, great user interface for navigation and printing, and it imports html files as well as .zips up for portability. HUGE VOTE for this in core! Thanks!

          Show
          Mary Parke added a comment - I know of MANY institutions that would also love to see this in core. It's simple, elegant, great user interface for navigation and printing, and it imports html files as well as .zips up for portability. HUGE VOTE for this in core! Thanks!
          Hide
          Mary Parke added a comment -

          How is it no one has been assigned to this ticket? Book in core would be awesome!

          Show
          Mary Parke added a comment - How is it no one has been assigned to this ticket? Book in core would be awesome!
          Hide
          Jean-François Dragon added a comment -

          As my institution is not well inclined to integrate contributed modules into our Moodle installation and I really need this module for my courses development, I'll vote twice for this issue if I could!!

          Can we hope to see it in Moodle 2.2?

          Show
          Jean-François Dragon added a comment - As my institution is not well inclined to integrate contributed modules into our Moodle installation and I really need this module for my courses development, I'll vote twice for this issue if I could!! Can we hope to see it in Moodle 2.2?
          Hide
          Petr Škoda added a comment -

          I am sorry, book will not be part of official distribution because after contrib plugin becomes part Moodle the original author loose control over it. I was thinking about major changes in mod/book for a long time, I would not be able to do that if book was part of official distribution.

          I already proposed to include a simple multi-page resource instead of book, but unfortunately it was not accepted.

          I am working on the book 2.1 version right now, hopefully it will be available next week from the new plugins database.

          Thank you for using book,

          Ciao

          Show
          Petr Škoda added a comment - I am sorry, book will not be part of official distribution because after contrib plugin becomes part Moodle the original author loose control over it. I was thinking about major changes in mod/book for a long time, I would not be able to do that if book was part of official distribution. I already proposed to include a simple multi-page resource instead of book, but unfortunately it was not accepted. I am working on the book 2.1 version right now, hopefully it will be available next week from the new plugins database. Thank you for using book, Ciao
          Hide
          Brent Lee added a comment -

          Thanks Petr!

          Do you have a repository where I can download to test Book 2.1?

          Cheers,

          Brent.

          Show
          Brent Lee added a comment - Thanks Petr! Do you have a repository where I can download to test Book 2.1? Cheers, Brent.
          Hide
          Petr Škoda added a comment -

          https://github.com/skodak/moodle-mod_book
          but it is not yet ready for testing

          Show
          Petr Škoda added a comment - https://github.com/skodak/moodle-mod_book but it is not yet ready for testing
          Hide
          Martin Dougiamas added a comment -

          At some future time we would like to put Book in core.

          Show
          Martin Dougiamas added a comment - At some future time we would like to put Book in core.
          Hide
          Petr Škoda added a comment -

          Hello,

          I have just released a final version of Book module for Moodle 2.1 http://moodle.org/plugins/view.php?plugin=mod_book
          I have cleaned up the codebase and fixed all know issues (except the missing file management), it is also compatible with current Moodle 2.2dev.

          I am looking for a new maintainer of this module because I am not going to maintain it in the future. Maybe if I find some time and funding I might work on a new more advanced module.

          Martin: feel free to include it in official distribution if you want to.

          Ciao and thanks for all your support and feedback over the years!

          Petr

          Show
          Petr Škoda added a comment - Hello, I have just released a final version of Book module for Moodle 2.1 http://moodle.org/plugins/view.php?plugin=mod_book I have cleaned up the codebase and fixed all know issues (except the missing file management), it is also compatible with current Moodle 2.2dev. I am looking for a new maintainer of this module because I am not going to maintain it in the future. Maybe if I find some time and funding I might work on a new more advanced module. Martin: feel free to include it in official distribution if you want to. Ciao and thanks for all your support and feedback over the years! Petr
          Hide
          Michael Lewis added a comment -

          It's clear that Petr has decided to no longer maintain Book module (though I still see some recent activity fixing minor bugs - for which much thanks). At some point Petr stated he did not want Book in core because he would lose control. Martin, you're on record as stating you'd like Book in core. Can we have a clear, reasoned explanation of current or future plans for the Book module - we have Books in many courses that will need to be re-written to use an alternative navigation, if we cannot expect Book to work in future Moodle versions (2.2+). Many thanks!

          Show
          Michael Lewis added a comment - It's clear that Petr has decided to no longer maintain Book module (though I still see some recent activity fixing minor bugs - for which much thanks). At some point Petr stated he did not want Book in core because he would lose control. Martin, you're on record as stating you'd like Book in core. Can we have a clear, reasoned explanation of current or future plans for the Book module - we have Books in many courses that will need to be re-written to use an alternative navigation, if we cannot expect Book to work in future Moodle versions (2.2+). Many thanks!
          Hide
          Paul Vaughan added a comment -

          If the Book module doesn't go into core, then I would like throw my hat into the ring and nominate myself as a potential maintainer. Keen, enthusiastic, been using Moodle and developing bits and bobs of code for/since 1.9, PHP/MySQL developer for >10 years... I can probably find a few people to vouch for me and provide a resume if required.

          Show
          Paul Vaughan added a comment - If the Book module doesn't go into core, then I would like throw my hat into the ring and nominate myself as a potential maintainer. Keen, enthusiastic, been using Moodle and developing bits and bobs of code for/since 1.9, PHP/MySQL developer for >10 years... I can probably find a few people to vouch for me and provide a resume if required.
          Hide
          Martin Dougiamas added a comment -

          Eloy has been tasked with this for some weeks now.

          Show
          Martin Dougiamas added a comment - Eloy has been tasked with this for some weeks now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I've moved the original CONTRIB issue to the MDL project for better tracking it.

          Right now, i'm in the process of fixing various aspects of the module (deprecated uses, coding style, phpdocs, db schema, upgrade...) but I have not found any stopper up to now. So I'm positive thinking this will land in days.

          Will post link to the integration branch I'm working on soon...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I've moved the original CONTRIB issue to the MDL project for better tracking it. Right now, i'm in the process of fixing various aspects of the module (deprecated uses, coding style, phpdocs, db schema, upgrade...) but I have not found any stopper up to now. So I'm positive thinking this will land in days. Will post link to the integration branch I'm working on soon...ciao
          Hide
          Martin Dougiamas added a comment -

          And Paul, thanks for the kind offer! Even when it does go into core, if Petr doesn't want to do it, would you like to be the official component lead (in charge of vetting/producing fixes and submitting them for integration)?

          Show
          Martin Dougiamas added a comment - And Paul, thanks for the kind offer! Even when it does go into core, if Petr doesn't want to do it, would you like to be the official component lead (in charge of vetting/producing fixes and submitting them for integration)?
          Hide
          Paul Vaughan added a comment -

          Certainly. Happy to help and be more formally involved with Moodle.

          Show
          Paul Vaughan added a comment - Certainly. Happy to help and be more formally involved with Moodle.
          Hide
          Petr Škoda added a comment -

          Hi, the recommended way to become maintainer of anything is to first start reporting problems and then submit pull requests with solutions. That proves that you understand the code, know how to use git and in general understand the development workflow. It also helps you to make personal connections with previous maintainers and most importantly your future users and the whole community. It also helps if you describe your vision how the plugin should evolve in the future. Anyway it is great to see that there are people willing to continue with book development, thanks and ciao. Petr

          Show
          Petr Škoda added a comment - Hi, the recommended way to become maintainer of anything is to first start reporting problems and then submit pull requests with solutions. That proves that you understand the code, know how to use git and in general understand the development workflow. It also helps you to make personal connections with previous maintainers and most importantly your future users and the whole community. It also helps if you describe your vision how the plugin should evolve in the future. Anyway it is great to see that there are people willing to continue with book development, thanks and ciao. Petr
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Great, Paul. Nice, Petr.

          For reference, here it's the current review in progress code, already integrated in to core:

          https://github.com/stronk7/moodle/commits/book_integration

          and here it's the (dirty) summary list of pending tasks I've to perform over it, FYI:

          Review:
          
          ▪ Comments (done)
          ▪ missing MOODLE_INTERNAL (done)
          ▪ deprecated stuff (in progress, see pending)
          ▪ phpdocs (done)
          ▪ coding guidelines
          ▪ whitespace
          ▪ upgrade
          ▪ backup
          ▪ moodle1
          ▪ version
          ▪ add plugin and subplugins as core ones
          ▪ $PAGE->set_pagelayout('admin');  hack?
          ▪ "Dear users…" => out.
          
          Pending:
          
          • grep -r 'get_context_instance(' * | grep '>instance' (4 usos, correct?)
          • grep -lr 'if (empty($PAGE->cm->context)' * (SamM, forum, cm_infp)
          • grep -lr '$PAGE->cm->context' * (deprecated or no)
          
          Testing instructions:
          
          • cover all functionalities (files support, imscp, importhtml, print. backup & restore, restore from 1.x…). Propose as MDLQA candidates.
          
          Other:
          
          • Look to existing docs
          • Look to existing issues in the tracker
          • Look to issues & pull requests @ github
          

          As said, it will be completed this week. That's the goal.

          Show
          Eloy Lafuente (stronk7) added a comment - Great, Paul. Nice, Petr. For reference, here it's the current review in progress code, already integrated in to core: https://github.com/stronk7/moodle/commits/book_integration and here it's the (dirty) summary list of pending tasks I've to perform over it, FYI: Review: ▪ Comments (done) ▪ missing MOODLE_INTERNAL (done) ▪ deprecated stuff (in progress, see pending) ▪ phpdocs (done) ▪ coding guidelines ▪ whitespace ▪ upgrade ▪ backup ▪ moodle1 ▪ version ▪ add plugin and subplugins as core ones ▪ $PAGE->set_pagelayout('admin'); hack? ▪ "Dear users…" => out. Pending: • grep -r 'get_context_instance(' * | grep '>instance' (4 usos, correct?) • grep -lr ' if (empty($PAGE->cm->context)' * (SamM, forum, cm_infp) • grep -lr '$PAGE->cm->context' * (deprecated or no) Testing instructions: • cover all functionalities (files support, imscp, importhtml, print. backup & restore, restore from 1.x…). Propose as MDLQA candidates. Other: • Look to existing docs • Look to existing issues in the tracker • Look to issues & pull requests @ github As said, it will be completed this week. That's the goal.
          Hide
          Martin Dougiamas added a comment -

          Current status?

          Show
          Martin Dougiamas added a comment - Current status?
          Hide
          Petr Škoda added a comment -

          Eloy: here is a branch with full mod_book history rebased on top of current master https://github.com/skodak/moodle/commits/book_migration together with your changes.

          I think we should use it because:

          • we should not throw away git commit authors during transition to new repo (this is very different from our imports of libraries into moodle, we do not maintain/modify them in moodle)
          • git annotate shows commit info
          • no extra git root
          Show
          Petr Škoda added a comment - Eloy: here is a branch with full mod_book history rebased on top of current master https://github.com/skodak/moodle/commits/book_migration together with your changes. I think we should use it because: we should not throw away git commit authors during transition to new repo (this is very different from our imports of libraries into moodle, we do not maintain/modify them in moodle) git annotate shows commit info no extra git root
          Hide
          Andrew Nicols added a comment -

          There's a new string for modulename_help in https://docs.google.com/document/d/1KTZUWRJEqLdBKTInmrY4USliyZZD93lE4pWGBAjxG5w/edit

          Also could you set $string['modulename_link'] to 'mod/book/view' in the language files.

          Show
          Andrew Nicols added a comment - There's a new string for modulename_help in https://docs.google.com/document/d/1KTZUWRJEqLdBKTInmrY4USliyZZD93lE4pWGBAjxG5w/edit Also could you set $string ['modulename_link'] to 'mod/book/view' in the language files.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Thanks, Andrew. Added.

          Show
          Eloy Lafuente (stronk7) added a comment - Thanks, Andrew. Added.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Oki, I think I've finished polishing the most important points I've found.

          Surely there will be some things to fix/improve along the next days, but better we send this to integration at this point.

          Please, about anything related with book and its integration in core, let's all create subtasks of this (or linked to this issues). That will help having everything under control.

          I'm about to create some issues right now to have all them under the radar.

          Ciao

          PS: Finally, after discussion with integrators, we have agreed the best way for this to land is via subtree merge and not rebase. It keeps history intact and doesn't pollute master history with a lot of old commits. So the branch above has the integration performed that way.

          Show
          Eloy Lafuente (stronk7) added a comment - Oki, I think I've finished polishing the most important points I've found. Surely there will be some things to fix/improve along the next days, but better we send this to integration at this point. Please, about anything related with book and its integration in core, let's all create subtasks of this (or linked to this issues). That will help having everything under control. I'm about to create some issues right now to have all them under the radar. Ciao PS: Finally, after discussion with integrators, we have agreed the best way for this to land is via subtree merge and not rebase. It keeps history intact and doesn't pollute master history with a lot of old commits. So the branch above has the integration performed that way.
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          TODO: To be created as sub-tasks/linked issues, writing them here to avoid forgetting.

          1) MDLTEST-151: Complete the mod_book MDLQA tests.
          2) MDL-33120: Play the module completely and review all the English strings.
          3) MDL-33129: Verify all the Moodle Docs related with the module.
          4) Done (Eloy): Move all opened CONTRIB issues to MDL ones (keep the resolved/closed ones).
          5) Done (Eloy): #9, #22, #23. Look for existing issues @ github and move them to MDL too. These have been created: MDL-33219, MDL-33206, MDL-33361, MDL-33362.
          6) Create issue about to review the "view all" log action across all modules.
          7) $PAGE->cm->context, to be (used) or not to be (used). Right now it's "deprecated".
          8) Create issue about xxx_user_complete() and xxx_user_outline(), both using $info instead of indexed course & cm.
          9) Done (SamH): Delete .gitignore. I had it deleted in my previous branches but just detected I missed to delete it in the last merge. My fault.

          That's all, apart from the issues that I'm sure this* clever integrator will find.

          Ciao

          • this: not me, but the integrator of this (issue). LOL.
          Show
          Eloy Lafuente (stronk7) added a comment - - edited TODO: To be created as sub-tasks/linked issues, writing them here to avoid forgetting. 1) MDLTEST-151 : Complete the mod_book MDLQA tests. 2) MDL-33120 : Play the module completely and review all the English strings. 3) MDL-33129 : Verify all the Moodle Docs related with the module. 4) Done (Eloy): Move all opened CONTRIB issues to MDL ones (keep the resolved/closed ones). 5) Done (Eloy): #9, #22, #23. Look for existing issues @ github and move them to MDL too. These have been created: MDL-33219 , MDL-33206 , MDL-33361 , MDL-33362 . 6) Create issue about to review the "view all" log action across all modules. 7) $PAGE->cm->context, to be (used) or not to be (used). Right now it's "deprecated". 8) Create issue about xxx_user_complete() and xxx_user_outline(), both using $info instead of indexed course & cm. 9) Done (SamH): Delete .gitignore. I had it deleted in my previous branches but just detected I missed to delete it in the last merge. My fault. That's all, apart from the issues that I'm sure this* clever integrator will find. Ciao this: not me, but the integrator of this (issue). LOL.
          Hide
          Sam Hemelryk added a comment -

          Eloy asked me to look at this today and my review is no under way. Providing there are no blockers this will be integrated and any further issues will need to be turned into sub tasks to be dealt with after integration (and preferably before 2.3 release).

          Show
          Sam Hemelryk added a comment - Eloy asked me to look at this today and my review is no under way. Providing there are no blockers this will be integrated and any further issues will need to be turned into sub tasks to be dealt with after integration (and preferably before 2.3 release).
          Hide
          Sam Hemelryk added a comment -

          Hoorah this has been integrated!
          Congrats all, mammoth effort!

          During my review I noted the following things that I will create subtasks for now:

          • README.md needs updating to reflect its integration into core. Not urgent but before release probably (defintely "no more developement planned" ).
          • Simple observation renderers arn't being used.
          • The opening line of the boilerplate for each file is inconsistent. Some say part of Moodle, others Book module for Moodle, and others again Book plugin for Moodle.
          • I couldn't find or determine a use for book_log function in locallib.php
          • book_get_toc would be great to convert output to use either a renderer preferably or at least standard output mechanics.
          • faq_help string details that global search doesn't work for the book module in a way only developers will actually understand. As teachers are going to be the main viewer of that part of the string I think we should refactor it to be polite and generalistic. The book module does not provide a search mechanism. Also artifical line wrappings in that string should be removed. Line wrapping should be determined by the display of the string.
          • customtitles_help string refers to Chapter titles, should that be custom titles.
          • numbering_help string I find slightly confusing. I think it should be something like:
            • None - chapter and subchapter titles are not automatically formatted. This allows you to use your own style within the title.
            • Numbers - chapters and subchapters are numbered automatically (1, 1.1, 1.2, 2, ...)
            • Bullets - subchapters are indented and displayed with bullets.
            • Indented - subchapters are indented.
          • I couldn't find the use of the chapterscount string. If it is used should that have a {$a}.
          • errorchapter string: I wonder whether that should be "Error finding book chapter" not a biggy just wondering.Y
          • $PAGE->set_title calls format_string internally (aweful) but mean no need to wrap things in format_string when setting page title[several files affected].
          • $PAGE->set_heading is the same as above.
          • Is there a need to add mod_book as a body class. You can be sure the body class path-mod-book has been added for all pages within the book module.
          • PARAM_RAW for the chapter title, is that correct will we allow HTML + friends there?
          • booktool_***_extend_settings_navigation no need to check modname !== book that has happened within the calling function book_extend_settings_navigation. (Lots of unused globals in those functions as well).
          • It would be nice if when editing the first chapter (such as when you've just created the activity) if the would freeze the "subchapter" option and add a note about it being frozen because the first page cannot be a subchapter. Just a smidge better than ignoring it for friendliness.
          • book_preload_chapters: next and prev values are never set correctly. Not a bug as they are also not used presently (but should be fixed or removed none the less).
          • tool/exportimscp/index.php unused lang string vars.

          I've also made a commit that makes the following changes before integration as these were obvious/straight forward:

          • Added a comment for the BOOK_NUM_* defines.
          • Fixed broken redirects in tool/importhtml/index.php
          • Fixed typo in book_preload_chapters [subchpaters => subchapters]
          • Fixed copy paste docblock error in tool/print/locallib.php
          • Removed the .gitignore file as Eloy had previously mentioned that.

          Big thanks
          Sam

          Show
          Sam Hemelryk added a comment - Hoorah this has been integrated! Congrats all, mammoth effort! During my review I noted the following things that I will create subtasks for now: README.md needs updating to reflect its integration into core. Not urgent but before release probably (defintely "no more developement planned" ). Simple observation renderers arn't being used. The opening line of the boilerplate for each file is inconsistent. Some say part of Moodle, others Book module for Moodle, and others again Book plugin for Moodle. I couldn't find or determine a use for book_log function in locallib.php book_get_toc would be great to convert output to use either a renderer preferably or at least standard output mechanics. faq_help string details that global search doesn't work for the book module in a way only developers will actually understand. As teachers are going to be the main viewer of that part of the string I think we should refactor it to be polite and generalistic. The book module does not provide a search mechanism. Also artifical line wrappings in that string should be removed. Line wrapping should be determined by the display of the string. customtitles_help string refers to Chapter titles, should that be custom titles. numbering_help string I find slightly confusing. I think it should be something like: None - chapter and subchapter titles are not automatically formatted. This allows you to use your own style within the title. Numbers - chapters and subchapters are numbered automatically (1, 1.1, 1.2, 2, ...) Bullets - subchapters are indented and displayed with bullets. Indented - subchapters are indented. I couldn't find the use of the chapterscount string. If it is used should that have a {$a}. errorchapter string: I wonder whether that should be "Error finding book chapter" not a biggy just wondering.Y $PAGE->set_title calls format_string internally (aweful) but mean no need to wrap things in format_string when setting page title [several files affected] . $PAGE->set_heading is the same as above. Is there a need to add mod_book as a body class. You can be sure the body class path-mod-book has been added for all pages within the book module. PARAM_RAW for the chapter title, is that correct will we allow HTML + friends there? booktool_***_extend_settings_navigation no need to check modname !== book that has happened within the calling function book_extend_settings_navigation. (Lots of unused globals in those functions as well). It would be nice if when editing the first chapter (such as when you've just created the activity) if the would freeze the "subchapter" option and add a note about it being frozen because the first page cannot be a subchapter. Just a smidge better than ignoring it for friendliness. book_preload_chapters: next and prev values are never set correctly. Not a bug as they are also not used presently (but should be fixed or removed none the less). tool/exportimscp/index.php unused lang string vars. I've also made a commit that makes the following changes before integration as these were obvious/straight forward: Added a comment for the BOOK_NUM_* defines. Fixed broken redirects in tool/importhtml/index.php Fixed typo in book_preload_chapters [subchpaters => subchapters] Fixed copy paste docblock error in tool/print/locallib.php Removed the .gitignore file as Eloy had previously mentioned that. Big thanks Sam
          Hide
          Ankit Agarwal added a comment -

          I played around with the module and everything seems working great. Encountered a small numbering issue, created MDL-33123 for that.
          Passing this!
          Thanks

          Show
          Ankit Agarwal added a comment - I played around with the module and everything seems working great. Encountered a small numbering issue, created MDL-33123 for that. Passing this! Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!
          Hide
          Helen Foster added a comment -

          docs_required label removed as book module documentation now available: http://docs.moodle.org/23/en/Book_module

          Many thanks to everyone who has helped getting the book module into core!

          Show
          Helen Foster added a comment - docs_required label removed as book module documentation now available: http://docs.moodle.org/23/en/Book_module Many thanks to everyone who has helped getting the book module into core!

            People

            • Votes:
              102 Vote for this issue
              Watchers:
              43 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: