Thanks for reporting that. I was able to replicate the problem.

I've put that on the backlog.

In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

This bug applies also to upgraded installations (from 1.9 to 2.2).

I've started poking at a patch. I think the root problem is that the format field is mostly unused in 1.9, since whether to display the rich-text editor is a user preference. The default value is 0 and it doesn't get touched during the upgrade. I have a partial patch for the upgrade scenario: https://github.com/mackensen/moodle/compare/MOODLE_22_STABLE...MDL-32712-22.

I thought I would mention for anyone who has already upgraded all their 2.2 assignments to 2.3 mod_assign assignments without the benefit of Charles' patch that you can correct the situation in bulk by running this SQL on your database:

update mdl_assign set introformat = 1 where introformat = 0;

I'm going to submit the partial patch for review, since the upgrade issue only affects 2.2 and earlier but the backup/restore part also needs to be addressed in 2.3 and 2.4.

David: Could you please peer review this?

you guys rock, thanks for fixing this!

This is tightly related to MDL-34586

Again, as in MDL-34586, why not to follow the way other modules went? See for example the upgrade step 2009042003 in mod/forum/db/upgrade.php. We can't just set the format field without making sure that the text is converted into real HTML, too. And also, that forum code shows how to consider cases when HTML editor has been disabled site-wide.

Rewritten per MDL-34586.

Yup, looking good now. Thanks for the patch Charles!

Note: fixed typo on line 159; wrong variable name.

Does this need sending to integration?

@Dan: yep.

Sending all 'waiting for peer review' issues to integration before freeze, as agreed in Integrators Meeting 19/10/12. We are doing this to ensure any 'integratable issues' will not got missed before freeze..

Thanks Charles, integrated to 22 only.

Sorry Guys,

I am still seeing moodle auto-format in activity description, after restoring course.

Steps:

1. Created a course in 19 with text activity and editor was tinymce
2. Backed up 19 course and restored in integration 22
3. Went to activity and click edit settings
4. Description is moodle auto-format.

@Rajesh, I think I confused the issue along the way but this patch only covers the 1.9-2.2 upgrade scenario (which the testing instructions don't cover). The backup/restore scenario is in MDL-34586, which I think was reviewed and needs to be integrated. I think they're split up because this one is 2.2 only and the other should be in master and below.

Sorry Charles,

I didn't look at related issue. Followed test instructions and it didn't work as mentioned.

Will request Dan to reopen this for testing. I will just update site from 1.9 -> 2.2 and check if I can see TinyMCE.

Thanks Charles,

Patch works great for upgrade from 1.9 -> 2.2.
Can see TinyMCE in Assignment description.

Hurray!

You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4