Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31167 PHP strict META
  3. MDL-32717

While uninstallling a message processor I got a strict standards warning

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      Go to Site Administration > Plugins > Plugins Overview and click Uninstall next to the Jabber messaging processor.

      Go through the uninstallation process. Check that no strict standards warning are displayed.

      Go to Site Administration > Notifications to reinstall the Jabber processor.

      Show
      Go to Site Administration > Plugins > Plugins Overview and click Uninstall next to the Jabber messaging processor. Go through the uninstallation process. Check that no strict standards warning are displayed. Go to Site Administration > Notifications to reinstall the Jabber processor.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32009-master-3

      Description

      "Strict Standards: Creating default object from empty value in /home/andrew/Desktop/code/moodle/int/master/admin/message.php on line 73 "

      This appeared during the un-installation of a message processor. Site Administration > Plugins > Plugins Overview), scroll down to Messaging processors. Click uninstall. I uninstalled the Jabber processor. Not sure if that is significant.

        Gliffy Diagrams

          Issue Links

            Activity

            andyjdavis Andrew Davis created issue -
            andyjdavis Andrew Davis made changes -
            Field Original Value New Value
            Testing Instructions Go to Site Administration > Plugins > Plugins Overview and click Uninstall next to the Jabber messaging processor.

            Go through the uninstallation process. Check that no strict standards warning are displayed.

            Go to Site Administration > Notifications to reinstall the Jabber processor.
            andyjdavis Andrew Davis made changes -
            Link This issue discovered while testing MDL-32009 [ MDL-32009 ]
            salvetore Michael de Raadt made changes -
            Parent MDL-31167 [ 50236 ]
            Issue Type Bug [ 1 ] Sub-task [ 5 ]
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            kabalin Ruslan Kabalin made changes -
            Assignee Andrew Davis [ andyjdavis ] Ruslan Kabalin [ kabalin ]
            Hide
            kabalin Ruslan Kabalin added a comment -

            Well spotted Andrew!

            Show
            kabalin Ruslan Kabalin added a comment - Well spotted Andrew!
            Hide
            kabalin Ruslan Kabalin added a comment -

            Added commit to fix it. Since MDL-32009 is not on public master yet, I add fix to this branch. It can be cleanly cherry-picked to master once the MDL-32009 is released.

            Show
            kabalin Ruslan Kabalin added a comment - Added commit to fix it. Since MDL-32009 is not on public master yet, I add fix to this branch. It can be cleanly cherry-picked to master once the MDL-32009 is released.
            kabalin Ruslan Kabalin made changes -
            kabalin Ruslan Kabalin made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Peer reviewer dobedobedoh
            dobedobedoh Andrew Nicols made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Looks good to me

            Show
            dobedobedoh Andrew Nicols added a comment - Looks good to me
            dobedobedoh Andrew Nicols made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            kabalin Ruslan Kabalin made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            samhemelryk Sam Hemelryk made changes -
            Fix Version/s 2.3 [ 10657 ]
            poltawski Dan Poltawski made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator poltawski
            Currently in integration Yes [ 10041 ]
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks, i've integrated this now

            Show
            poltawski Dan Poltawski added a comment - Thanks, i've integrated this now
            poltawski Dan Poltawski made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s STABLE backlog [ 10463 ]
            timb Tim Barker made changes -
            Tester nebgor
            timb Tim Barker made changes -
            Tester nebgor rwijaya
            rwijaya Rossiani Wijaya made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This is working fine.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This is working fine. Test passed.
            rwijaya Rossiani Wijaya made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

            Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 11/May/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12