Moodle
  1. Moodle
  2. MDL-32728

Weeks format will display wrong hide / show string.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Course
    • Labels:
      None
    • Rank:
      39689

      Description

      Looking at the 'https://github.com/danpoltawski/moodle/tree/MDL-31052-js-rewrite' branch for MDL-31052 (also integrated into 'https://github.com/moodle/moodle/blob/master/course/format/weeks/format.php'), there is a coding fault in '/course/format/weeks/format.php' where

              $strweekhide = get_string('hidefromothers', 'format_topics');
              $strweekshow = get_string('showfromothers', 'format_topics');
      

      should be

              $strweekhide = get_string('hidefromothers', 'format_weeks');
              $strweekshow = get_string('showfromothers', 'format_weeks');
      

      Lines 50 & 51.

        Issue Links

          Activity

          Hide
          Gareth J Barnard added a comment -

          Found whilst learning code change.

          Show
          Gareth J Barnard added a comment - Found whilst learning code change.
          Hide
          Ruslan Kabalin added a comment -

          Introduced by MDL-31096 in fact.

          Show
          Ruslan Kabalin added a comment - Introduced by MDL-31096 in fact.
          Hide
          Gareth J Barnard added a comment - - edited

          Fair enough introduced in MDL-31096, but statement is still true with the logical predicate that I spotted it whilst looking at MDL-31052.

          But what the heck! Its an issue that needs fixing. Feel the fellow developer 'love' for something spotted before release to users

          Show
          Gareth J Barnard added a comment - - edited Fair enough introduced in MDL-31096 , but statement is still true with the logical predicate that I spotted it whilst looking at MDL-31052 . But what the heck! Its an issue that needs fixing. Feel the fellow developer 'love' for something spotted before release to users
          Hide
          Ruslan Kabalin added a comment -

          Patch is added

          Show
          Ruslan Kabalin added a comment - Patch is added
          Hide
          Andrew Nicols added a comment -

          Looks good to me.

          Show
          Andrew Nicols added a comment - Looks good to me.
          Hide
          Dan Poltawski added a comment -

          This has already been fixed MDL-32508

          Show
          Dan Poltawski added a comment - This has already been fixed MDL-32508
          Hide
          Dan Poltawski added a comment -

          Closing as fixed by 1804b7c1bc99667198d865b56a5af3158d532de5
          in MDL-32508

          Show
          Dan Poltawski added a comment - Closing as fixed by 1804b7c1bc99667198d865b56a5af3158d532de5 in MDL-32508

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: