Moodle
  1. Moodle
  2. MDL-32742

Course highlight/visibility issues with drag-drop

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: AJAX and JavaScript, Course
    • Labels:
      None
    • Testing Instructions:
      Hide

      For testing highlighted section issue:

      For testing hidden section issue:

      1. Open course and enable editing
      2. Mark one section as invisible
      3. Move hidden section
      4. Ensure that the close eye icon remains at the hidden section (before fix, it appeared near the section of the original location of hidden one).
      Show
      For testing highlighted section issue: see testing instructions of MDL-32875 For testing hidden section issue: Open course and enable editing Mark one section as invisible Move hidden section Ensure that the close eye icon remains at the hidden section (before fix, it appeared near the section of the original location of hidden one).
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32742-master-1

      Description

      The new drag-drop in MDL-31052 introduced some issues:

      • When the highlighted section is dragged to the new place, no database updates are being made, so the original section remains highlighted on page refresh.
      • When the hidden section is dragged to the new place, the section visibility icons remain on its original places (die to right part with icons swap we do in the format).

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Ruslan Kabalin added a comment -

            The first bit will be resolved by MDL-32875

            Show
            Ruslan Kabalin added a comment - The first bit will be resolved by MDL-32875
            Hide
            Ruslan Kabalin added a comment -

            Added the patch

            Show
            Ruslan Kabalin added a comment - Added the patch
            Hide
            Ruslan Kabalin added a comment -

            Andrew, can you please review this one. Thanks.

            Show
            Ruslan Kabalin added a comment - Andrew, can you please review this one. Thanks.
            Hide
            Andrew Nicols added a comment -

            Code looks correct and works as expected.

            Show
            Andrew Nicols added a comment - Code looks correct and works as expected.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Thanks, i've integrated this now

            Show
            Dan Poltawski added a comment - Thanks, i've integrated this now
            Hide
            Ankit Agarwal added a comment -

            Working as expected.
            passing
            thanks

            Show
            Ankit Agarwal added a comment - Working as expected. passing thanks
            Hide
            Eloy Lafuente (stronk7) added a comment -

            U P S T R E A M I Z E D !

            Many thanks for the hard work, closing this as fixed.

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: