Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32743

New resource javascript icons can't be accessed with keyboard

    Details

    • Testing Instructions:
      Hide
      • open course page
      • turn editing on
      • tab to a command area
        • ensure that all icons are selectable
      • indent right an activity for the first time
        • ensure that the indent left icon is also tabbable

      Please note that the drag/drop icon cannot be tabbed to (it doesn't support keyboard drag/drop)

      Show
      open course page turn editing on tab to a command area ensure that all icons are selectable indent right an activity for the first time ensure that the indent left icon is also tabbable Please note that the drag/drop icon cannot be tabbed to (it doesn't support keyboard drag/drop)
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32743-master-2

      Description

      It's no longer possible to tab to each of the javascript icons (e.g. left, right, delete, show/hide).

      This is caused by a removal of the href attribute on the anchor.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            kabalin Ruslan Kabalin added a comment -

            +1

            Show
            kabalin Ruslan Kabalin added a comment - +1
            Hide
            kabalin Ruslan Kabalin added a comment -

            Although it is used everywhere, using hash in href is not good from semantics point, preserving the original link would look better (even though it would be overriden by js action).

            Show
            kabalin Ruslan Kabalin added a comment - Although it is used everywhere, using hash in href is not good from semantics point, preserving the original link would look better (even though it would be overriden by js action).
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Thanks for that thought Ruslan.

            I've made the suggested change and add e.preventDefault() to all events.

            Show
            dobedobedoh Andrew Nicols added a comment - Thanks for that thought Ruslan. I've made the suggested change and add e.preventDefault() to all events.
            Hide
            kabalin Ruslan Kabalin added a comment -

            Looks good, thanks Andrew.

            Show
            kabalin Ruslan Kabalin added a comment - Looks good, thanks Andrew.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys, code looks good and this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys, code looks good and this has been integrated now
            Hide
            fred Frédéric Massart added a comment -

            Test successful

            Show
            fred Frédéric Massart added a comment - Test successful
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

            Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12