Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32745

Course ajax causes JS errors when used in site main menu block

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Blocks, JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      These tests should be completed with the javascript console open to check for errors.

      • Open the Site Front Page and turn editing on
      • In the central resource area:
      • Create a couple of activities including:
        • a label
        • an activity
        • another resource
      • try each of the AJAX functions to ensure that they work:
        • indent right
        • indent left
        • show
        • hide
        • group mode toggle (on the activity)
        • delete
      • If you don't already have it, add a 'Main Menu' block on the site front page
      • Create a couple of activities including:
        • a label
        • an activity
        • another resource
      • try each of the function icons – they should cause page reloads now:
        • show
        • hide
        • group mode toggle (on the activity)
        • delete
      • Open a course page and turn editing on
      • In the first topic/week area:
      • Create a couple of activities including:
        • a label
        • an activity
        • another resource
      • try each of the AJAX functions to ensure that they work:
        • indent right
        • indent left
        • show
        • hide
        • group mode toggle (on the activity)
        • delete
        • toggle the section/week visibility
      Show
      These tests should be completed with the javascript console open to check for errors. Open the Site Front Page and turn editing on In the central resource area: Create a couple of activities including: a label an activity another resource try each of the AJAX functions to ensure that they work: indent right indent left show hide group mode toggle (on the activity) delete If you don't already have it, add a 'Main Menu' block on the site front page Create a couple of activities including: a label an activity another resource try each of the function icons – they should cause page reloads now: show hide group mode toggle (on the activity) delete Open a course page and turn editing on In the first topic/week area: Create a couple of activities including: a label an activity another resource try each of the AJAX functions to ensure that they work: indent right indent left show hide group mode toggle (on the activity) delete toggle the section/week visibility
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32745-master-1

      Description

      I discovered that there's another location which has section menus - the site_main_menu block. At present we apply the JS to this, but the block doesn't provide enough information at present to automate it.

      It's probably a bit late in the game to start adding relevant data along with any rewrites of the javascript that might be required so I've got a fix to ensure that it's not within the scope and doesn't get instantiated.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Ruslan Kabalin
              Integrator:
              Dan Poltawski
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12