Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.3
    • Fix Version/s: DEV backlog
    • Component/s: Other
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      Instead of using !important CSS styles we should have our own YUI skin for displaying Panels, Tree, etc.

        Gliffy Diagrams

          Activity

          Hide
          Martin Dougiamas added a comment -

          Can we have more info here?

          Show
          Martin Dougiamas added a comment - Can we have more info here?
          Hide
          Marina Glancy added a comment -

          It turned out that skin is quite difficult to implement.
          Sam came out with another idea of placing all widgets inside an element with a fixed id and define styles for this id. Those styles will overwrite the styles for the class even defined later. It worked and we implemented it in MDL-33218. So maybe this issue needs to be closed.
          Sam, what do you think?

          Show
          Marina Glancy added a comment - It turned out that skin is quite difficult to implement. Sam came out with another idea of placing all widgets inside an element with a fixed id and define styles for this id. Those styles will overwrite the styles for the class even defined later. It worked and we implemented it in MDL-33218 . So maybe this issue needs to be closed. Sam, what do you think?
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          I think this can probably be closed.
          Skinning YUI is a difficult task and doing so would not only involve creating a skin based upon the currently used sam skin, but would also mean watching for and maintaining it during YUI upgrades.
          On top of that I think really all that we are doing 99% of the time is tweaking the way things look. There is normally a bit of a challenge in writting CSS for YUI components, the biggest being their strange usually not quite enough information docs. But they do think of people altering styles and tricks like the one Marina mentioned (bind styles to a parent with an id) normally do the trick and allow people to style with just the aid of tools like firebug.

          +1 from me to close this issue.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I think this can probably be closed. Skinning YUI is a difficult task and doing so would not only involve creating a skin based upon the currently used sam skin, but would also mean watching for and maintaining it during YUI upgrades. On top of that I think really all that we are doing 99% of the time is tweaking the way things look. There is normally a bit of a challenge in writting CSS for YUI components, the biggest being their strange usually not quite enough information docs. But they do think of people altering styles and tricks like the one Marina mentioned (bind styles to a parent with an id) normally do the trick and allow people to style with just the aid of tools like firebug. +1 from me to close this issue. Cheers Sam

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: