[MDL-32766] Sort out log entries for section views - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Master Branch:
~~MDL-32766~~
Pull Master Diff URL:
https://github.com/rwijaya/moodle/compare/master...MDL-32766
Testing Instructions:
Hide

As teacher

set course layout setting to "show one section per page"

access a course (topic/week format) and select couples of section (eg: http://moodle/course/view.php?id=xx&section=3)

check the log report for the course and make sure there's "course view section" entry

As admin

backup the course and tick on "include course logs"

restore the course as new course

check the log for the new course and make sure there's "course view section" entry.
Show
As teacher set course layout setting to "show one section per page" access a course (topic/week format) and select couples of section (eg: http://moodle/course/view.php?id=xx&section=3 ) check the log report for the course and make sure there's "course view section" entry As admin backup the course and tick on "include course logs" restore the course as new course check the log for the new course and make sure there's "course view section" entry.

We need to do something about course view entries, perhaps we will need to add a new one for a section page view

//TODO: danp do we need different urls?

add_to_log($course->id, 'course', 'view', "view.php?id=$course->id", "$course->id");

caused a regression

MDL-33502 Unnecessary handling of files based on sectionnumber

has been marked as being related by

MDL-33465 Log entries should use sectionid instead of section parameter

MDL-33606 There is no distinction between all section course view and a single section course view log entry

will be (partly) resolved by

MDL-33369 We need to add a new optional sectionid parameter to refer to course sections and not be dependent on section changes

Participants:: Ankit Agarwal, Aparup Banerjee, Dan Poltawski, Eloy Lafuente (stronk7), Rossiani Wijaya, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)