Moodle
  1. Moodle
  2. MDL-32775

moodle media dialog has moodlemedia.htm referring to wrong pix path.

    Details

      Description

      Discovered while testing MDL-32680, when opening up the moodle media dialog from tinymce the following notice is seen:

      File does not exist: /home/aparup/mcode/pix, referer: http://aparup.moodle.local/integration/lib/editor/tinymce/tiny_mce/3.5/plugins/moodlemedia/moodlemedia.htm

      Dan has spotted a '../' miscount somewhere in lib/editor/tinymce../moodlemedia/media.css : line 8 url(../../../../../../../../../pix/a/search.png)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Poltawski added a comment - - edited

            Hmm. What I don't understand about this is that I can see the search icon before integrating.

            git grep search.png
            tinymce/tiny_mce/3.5/plugins/advimage/css/advimage.css:    background: url(../../../../../../../../pix/a/search.png) .2em .3em no-repeat;
            tinymce/tiny_mce/3.5/plugins/moodlemedia/css/media.css:    background: url(../../../../../../../../../pix/a/search.png) .2em .3em no-repeat;
            

            Show
            Dan Poltawski added a comment - - edited Hmm. What I don't understand about this is that I can see the search icon before integrating. git grep search.png tinymce/tiny_mce/3.5/plugins/advimage/css/advimage.css: background: url(../../../../../../../../pix/a/search.png) .2em .3em no-repeat; tinymce/tiny_mce/3.5/plugins/moodlemedia/css/media.css: background: url(../../../../../../../../../pix/a/search.png) .2em .3em no-repeat;
            Hide
            Dan Poltawski added a comment -

            (see the search icoon in interface I mean) - that grep was just for my own interest

            Show
            Dan Poltawski added a comment - (see the search icoon in interface I mean) - that grep was just for my own interest
            Hide
            Petr Skoda added a comment -

            weird, I hope the relative path base is not browser dependant. In anycase this smells because we should not link pix dir like this, all icons should be part of the tinymce plugin.

            Show
            Petr Skoda added a comment - weird, I hope the relative path base is not browser dependant. In anycase this smells because we should not link pix dir like this, all icons should be part of the tinymce plugin.
            Hide
            Dan Poltawski added a comment -

            I'm wondering if this code is even used..

            Show
            Dan Poltawski added a comment - I'm wondering if this code is even used..
            Hide
            Dan Poltawski added a comment -

            Well, this is obviously correct so i've integrated it anyway.

            Show
            Dan Poltawski added a comment - Well, this is obviously correct so i've integrated it anyway.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

            Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: