Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32780

Code cleanup in tool_assignmentupgrade. Change manual sql to use get_in_or_equal() and count_records_sql()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      View the assignment upgrade tool with 0 instances of mod_assignment.

      View the assignment upgrade tool with 1 instance of mod_assignment.

      View the assignment upgrade tool with > 1 instance of mod_assignment.

      (Site Administration -> Assignment upgrade helper)

      Should not report any SQL errors to the page.

      Show
      View the assignment upgrade tool with 0 instances of mod_assignment. View the assignment upgrade tool with 1 instance of mod_assignment. View the assignment upgrade tool with > 1 instance of mod_assignment. (Site Administration -> Assignment upgrade helper) Should not report any SQL errors to the page.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-32780-CLEAN

      Description

      Use Moodle functions for creating SQL rather than building the queries manually in functions:

      tool_assignmentupgrade_load_all_upgradable_assignmentids() and
      tool_assignmentupgrade_any_upgradable_assignments()

        Attachments

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            damyon Damyon Wiese
            Peer reviewer:
            Dan Poltawski
            Integrator:
            Sam Hemelryk
            Tester:
            Sam Hemelryk
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12