Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32782

Assignment upgrade tool - remove unused source file.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:

      Description

      admin/tool/assigumentupgrade/lib.php only contains a stub for a cron function and it is not used.

      It should be completely removed.

        Gliffy Diagrams

          Attachments

            Activity

            damyon Damyon Wiese created issue -
            damyon Damyon Wiese made changes -
            damyon Damyon Wiese made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Hide
            poltawski Dan Poltawski added a comment -

            Looks good to me Damyon, submitting for integration review.

            It'd be great if you could do this against the master branch too as I think its still based off your WIP branch.

            Show
            poltawski Dan Poltawski added a comment - Looks good to me Damyon, submitting for integration review. It'd be great if you could do this against the master branch too as I think its still based off your WIP branch.
            poltawski Dan Poltawski made changes -
            Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
            Hide
            damyon Damyon Wiese added a comment -

            Hi Dan,

            I cherry-picked this onto master as well (the other one was based on top of integration).

            • Damyon
            Show
            damyon Damyon Wiese added a comment - Hi Dan, I cherry-picked this onto master as well (the other one was based on top of integration). Damyon
            poltawski Dan Poltawski made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator poltawski
            Currently in integration Yes [ 10041 ]
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated thanks

            Show
            poltawski Dan Poltawski added a comment - Integrated thanks
            poltawski Dan Poltawski made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.3 [ 10657 ]
            poltawski Dan Poltawski made changes -
            Testing Instructions * Test the assignment upgrade tool and ensure it continues to work
            poltawski Dan Poltawski made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester poltawski
            Hide
            poltawski Dan Poltawski added a comment -

            Doesn't seem to affect anything so marking as tested.

            Show
            poltawski Dan Poltawski added a comment - Doesn't seem to affect anything so marking as tested.
            poltawski Dan Poltawski made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            salvetore Michael de Raadt made changes -
            Labels triaged
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

            Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 11/May/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12