Moodle
  1. Moodle
  2. MDL-32782

Assignment upgrade tool - remove unused source file.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:

      Description

      admin/tool/assigumentupgrade/lib.php only contains a stub for a cron function and it is not used.

      It should be completely removed.

        Gliffy Diagrams

          Activity

          Damyon Wiese created issue -
          Damyon Wiese made changes -
          Damyon Wiese made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Hide
          Dan Poltawski added a comment -

          Looks good to me Damyon, submitting for integration review.

          It'd be great if you could do this against the master branch too as I think its still based off your WIP branch.

          Show
          Dan Poltawski added a comment - Looks good to me Damyon, submitting for integration review. It'd be great if you could do this against the master branch too as I think its still based off your WIP branch.
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
          Hide
          Damyon Wiese added a comment -

          Hi Dan,

          I cherry-picked this onto master as well (the other one was based on top of integration).

          • Damyon
          Show
          Damyon Wiese added a comment - Hi Dan, I cherry-picked this onto master as well (the other one was based on top of integration). Damyon
          Dan Poltawski made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator poltawski
          Currently in integration Yes [ 10041 ]
          Hide
          Dan Poltawski added a comment -

          Integrated thanks

          Show
          Dan Poltawski added a comment - Integrated thanks
          Dan Poltawski made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.3 [ 10657 ]
          Dan Poltawski made changes -
          Testing Instructions * Test the assignment upgrade tool and ensure it continues to work
          Dan Poltawski made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester poltawski
          Hide
          Dan Poltawski added a comment -

          Doesn't seem to affect anything so marking as tested.

          Show
          Dan Poltawski added a comment - Doesn't seem to affect anything so marking as tested.
          Dan Poltawski made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Michael de Raadt made changes -
          Labels triaged
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

          Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 11/May/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: