Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32797

Change default Wiki "First page name" to be blank

    Details

    • Testing Instructions:
      Hide
      1. Log in as teacher
      2. Create new wiki
      3. Check "First page name" field is empty.
      4. Enter all required values and save wiki.
      5. No error should occur and name of the page should be same as entered in "First page name" field.
      Show
      Log in as teacher Create new wiki Check "First page name" field is empty. Enter all required values and save wiki. No error should occur and name of the page should be same as entered in "First page name" field.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-32797

      Description

      When creating a wiki the default value for "First page name" is "First page name". It should be blank and force the user to enter in a page name value, because if someone is not paying attention they will create a new wiki with a useless first page name and cannot change it.

      The request to change the first page name is in MDL-6488, but until that is implemented, it is better to prevent someone from ending up with a horrible default name.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            If this were to be changed, then the first page title would need to become a required field.

            Show
            salvetore Michael de Raadt added a comment - If this were to be changed, then the first page title would need to become a required field.
            Hide
            rex Rex Lorenzo added a comment -

            The first page title is already a required field.

            Show
            rex Rex Lorenzo added a comment - The first page title is already a required field.
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as I just documented this quirk in 2.2 and 2.3 http://docs.moodle.org/22/en/Wiki_settings#First_page_name

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as I just documented this quirk in 2.2 and 2.3 http://docs.moodle.org/22/en/Wiki_settings#First_page_name
            Hide
            salvetore Michael de Raadt added a comment -

            Yes, you're right, Rex. I should have checked that.

            Show
            salvetore Michael de Raadt added a comment - Yes, you're right, Rex. I should have checked that.
            Hide
            rajeshtaneja Rajesh Taneja added a comment - - edited

            Thanks for patch, Rex.

            IMO, rather then setting value to empty string, it should not be set. Also, this being an enhancement can only go in master.

            FYI:
            Adding docs_required label again, as default value will not be visible if this gets integrated.

            Show
            rajeshtaneja Rajesh Taneja added a comment - - edited Thanks for patch, Rex. IMO, rather then setting value to empty string, it should not be set. Also, this being an enhancement can only go in master. FYI: Adding docs_required label again, as default value will not be visible if this gets integrated.
            Hide
            fred Frédéric Massart added a comment -

            Code looks good, pushing for integration. Thanks guys!

            Show
            fred Frédéric Massart added a comment - Code looks good, pushing for integration. Thanks guys!
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Raj, i've integrated this now. Note that there are some linked issues which should probably be cleaned up.

            Show
            poltawski Dan Poltawski added a comment - Thanks Raj, i've integrated this now. Note that there are some linked issues which should probably be cleaned up.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            works as expected

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - works as expected Thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            YEAR!*

            CAF*, TOT!*

            • Your effort amazingly resulted. (unbelievable :-P)
            • Closing as fixed.
            • Tons of thanks.
            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as I have updated this in 2.4 docs http://docs.moodle.org/24/en/Wiki_settings

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as I have updated this in 2.4 docs http://docs.moodle.org/24/en/Wiki_settings

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12