Moodle

Change default Wiki "First page name" to be blank

Details

  • Testing Instructions:
    Hide
    1. Log in as teacher
    2. Create new wiki
    3. Check "First page name" field is empty.
    4. Enter all required values and save wiki.
    5. No error should occur and name of the page should be same as entered in "First page name" field.
    Show
    Log in as teacher Create new wiki Check "First page name" field is empty. Enter all required values and save wiki. No error should occur and name of the page should be same as entered in "First page name" field.
  • Affected Branches:
    MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-mdl-32797
  • Pull Master Diff URL:

Description

When creating a wiki the default value for "First page name" is "First page name". It should be blank and force the user to enter in a page name value, because if someone is not paying attention they will create a new wiki with a useless first page name and cannot change it.

The request to change the first page name is in MDL-6488, but until that is implemented, it is better to prevent someone from ending up with a horrible default name.

Issue Links

has been marked as being related by

Improvement - An enhancement to an existing Moodle feature. MDL-6488 Allow first page name to be changed

  • Major - Major loss of function, incorrect output
  • Open - The issue is open and ready for the assignee to start work on it.

Improvement - An enhancement to an existing Moodle feature. MDL-34694 Allow Wiki pages to be renamed

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

If this were to be changed, then the first page title would need to become a required field.

Show
Michael de Raadt added a comment - If this were to be changed, then the first page title would need to become a required field.
Hide
Permalink
Rex Lorenzo added a comment -

The first page title is already a required field.

Show
Rex Lorenzo added a comment - The first page title is already a required field.
Hide
Permalink
Mary Cooch added a comment -

Removing docs_required label as I just documented this quirk in 2.2 and 2.3 http://docs.moodle.org/22/en/Wiki_settings#First_page_name

Show
Mary Cooch added a comment - Removing docs_required label as I just documented this quirk in 2.2 and 2.3 http://docs.moodle.org/22/en/Wiki_settings#First_page_name
Hide
Permalink
Michael de Raadt added a comment -

Yes, you're right, Rex. I should have checked that.

Show
Michael de Raadt added a comment - Yes, you're right, Rex. I should have checked that.
Hide
Permalink
Rajesh Taneja added a comment - - edited

Thanks for patch, Rex.

IMO, rather then setting value to empty string, it should not be set. Also, this being an enhancement can only go in master.

FYI:
Adding docs_required label again, as default value will not be visible if this gets integrated.

Show
Rajesh Taneja added a comment - - edited Thanks for patch, Rex. IMO, rather then setting value to empty string, it should not be set. Also, this being an enhancement can only go in master. FYI: Adding docs_required label again, as default value will not be visible if this gets integrated.
Hide
Permalink
Frédéric Massart added a comment -

Code looks good, pushing for integration. Thanks guys!

Show
Frédéric Massart added a comment - Code looks good, pushing for integration. Thanks guys!
Hide
Permalink
Dan Poltawski added a comment -

Thanks Raj, i've integrated this now. Note that there are some linked issues which should probably be cleaned up.

Show
Dan Poltawski added a comment - Thanks Raj, i've integrated this now. Note that there are some linked issues which should probably be cleaned up.
Hide
Permalink
Ankit Agarwal added a comment -

works as expected

Thanks

Show
Ankit Agarwal added a comment - works as expected Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

YEAR!*

CAF*, TOT!*

  • Your effort amazingly resulted. (unbelievable :-P)
  • Closing as fixed.
  • Tons of thanks.
Show
Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.
Hide
Permalink
Mary Cooch added a comment -

Removing docs_required label as I have updated this in 2.4 docs http://docs.moodle.org/24/en/Wiki_settings

Show
Mary Cooch added a comment - Removing docs_required label as I have updated this in 2.4 docs http://docs.moodle.org/24/en/Wiki_settings

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: