Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.2.2, 2.3
-
Fix Version/s: 2.4
-
Component/s: Themes
-
Testing Instructions:
- Test formal_white theme in RTL
-
Affected Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-32806_master -
Pull Master Diff URL:
-
Rank:39826
Description
- Fix by swaping position of headermenu and logo divs in frontpage.php. general.php & report.php layout files to make left/right swap over of logo and lang menu easier to style in RTL mode :theme/formal_white/style/formal_white.css
- Fix position and alignment of "round corners" around frames, in RTL mode :theme/formal_white/style/frame.css by adding height and float to div container
Issue Links
- will help resolve
-
MDL-30337
RTL Theme fixes for Moodle 2.x.x
-
- Closed
-
Activity
Hi Mary,
We need some testing instructions for this. I'm gonna integrate it as I trust you and the changes look resonable to me, but i'd be great to have more there. Thanks 
Show
Dan Poltawski
added a comment - Hi Mary,
We need some testing instructions for this. I'm gonna integrate it as I trust you and the changes look resonable to me, but i'd be great to have more there. Thanks
Thanks Mary,
Formal white theme looks good in RTL mode.
Show
Rajesh Taneja
added a comment - Thanks Mary,
Formal white theme looks good in RTL mode.
Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!
ciao
Dan
Show
Dan Poltawski
added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!
ciao
Dan
Ciao Daniele,
When you have 5 minutes free could you please Peer Review some CSS & page layout changes to fix a few RTL bugs in Formal White? I'm trying to get them ready for when QA testing takes place as these are necessary fixes for Formal White.
Thank you.