Moodle

RTL Theme fixes for Moodle 2 (theme/formal_white)

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2.2, 2.3
  • Fix Version/s: 2.4
  • Component/s: Themes
  • Labels:

Description

  1. Fix by swaping position of headermenu and logo divs in frontpage.php. general.php & report.php layout files to make left/right swap over of logo and lang menu easier to style in RTL mode :theme/formal_white/style/formal_white.css
  1. Fix position and alignment of "round corners" around frames, in RTL mode :theme/formal_white/style/frame.css by adding height and float to div container

Issue Links

will help resolve

Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30337 RTL Theme fixes for Moodle 2.x.x

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mary Evans added a comment -

Ciao Daniele,

When you have 5 minutes free could you please Peer Review some CSS & page layout changes to fix a few RTL bugs in Formal White? I'm trying to get them ready for when QA testing takes place as these are necessary fixes for Formal White.

Thank you.

Show
Mary Evans added a comment - Ciao Daniele, When you have 5 minutes free could you please Peer Review some CSS & page layout changes to fix a few RTL bugs in Formal White? I'm trying to get them ready for when QA testing takes place as these are necessary fixes for Formal White. Thank you.
Hide
Permalink
Dan Poltawski added a comment -

Hi Mary,

We need some testing instructions for this. I'm gonna integrate it as I trust you and the changes look resonable to me, but i'd be great to have more there. Thanks

Show
Dan Poltawski added a comment - Hi Mary, We need some testing instructions for this. I'm gonna integrate it as I trust you and the changes look resonable to me, but i'd be great to have more there. Thanks
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Mary,

Formal white theme looks good in RTL mode.

Show
Rajesh Taneja added a comment - Thanks Mary, Formal white theme looks good in RTL mode.
Hide
Permalink
Dan Poltawski added a comment -

Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

ciao
Dan

Show
Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: