Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Go to Site Administration -> Plugins -> Activity Modules -> Manage Activities

      Delete the Assignment Activity

      Go to Site Administration -> Notifications

      Install the activity again.

      Should see separate sections for each assignment plugin with only it's own settings (Most only have "default").

      Show
      Go to Site Administration -> Plugins -> Activity Modules -> Manage Activities Delete the Assignment Activity Go to Site Administration -> Notifications Install the activity again. Should see separate sections for each assignment plugin with only it's own settings (Most only have "default").
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
      git@github.com:netspotau/moodle-mod_assign.git
    • Pull Master Branch:

      Description

      The mod/assign/settings.php need to be reworked:
      1/ nothing module related can appear on the new install page
      2/ mod_assign should not pollute global $CFG

      Ideally settings should affect only one plugin, once you start adding dependencies things start to break. In this particular case we need to apply default settings in manual install and cli upgrades, the mod_assign gets executed before the subplugins, it can not depend on its settings being set. I do not know any elegant solution here, maybe show all plugins in assign_feedback_plugin_for_gradebook and default to so known plugin.

      The second problem is that we can not keep adding module specific stuff to $CFG, long ago it was agreed that all new stuff goes config_plugins. Solution is to use:

      admin_setting_configselect('assign/feedback_plugin_for_gradebook')

      and the same for new admin_setting_configcheckbox('assignsubmission_' . $type . '_default', and otehr settings.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              increasing priority because ti should be imo fixed before the release

              Show
              skodak Petr Skoda added a comment - increasing priority because ti should be imo fixed before the release
              Hide
              damyon Damyon Wiese added a comment -

              Added a settings.php to each mod_assign plugin that at a minimum contains the 'default' setting. This way the plugins contain their own settings and the mod_assign does not need to list the available plugins at install time. Also changed all modules settings to use the config_plugins table.

              Regards, Damyon

              Show
              damyon Damyon Wiese added a comment - Added a settings.php to each mod_assign plugin that at a minimum contains the 'default' setting. This way the plugins contain their own settings and the mod_assign does not need to list the available plugins at install time. Also changed all modules settings to use the config_plugins table. Regards, Damyon
              Hide
              poltawski Dan Poltawski added a comment -

              I've integrated this - thanks.

              I was a little concerned about the lang string duplication (perhaps it'd be better to put a dependency on plugins and share strings). But I think those individual strings could be helpful.

              Show
              poltawski Dan Poltawski added a comment - I've integrated this - thanks. I was a little concerned about the lang string duplication (perhaps it'd be better to put a dependency on plugins and share strings). But I think those individual strings could be helpful.
              Hide
              abgreeve Adrian Greeve added a comment -

              Tested this on master first to see the difference. The integration version now had separate sections.
              Thanks.

              Show
              abgreeve Adrian Greeve added a comment - Tested this on master first to see the difference. The integration version now had separate sections. Thanks.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

              Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12