Moodle
  1. Moodle
  2. MDL-32821

META: RTL Theme fixes for Moodle 2 (Take 4)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Since the changes in this affect ALL CORE themes, each theme will need to be tested in the following areas when RTL language is enabled:

      1. CUSTOMMENU: test to see that the custom menu works language
      2. COLUMN SWAP: test to see that the left and right columns change place
      Show
      Since the changes in this affect ALL CORE themes, each theme will need to be tested in the following areas when RTL language is enabled: CUSTOMMENU: test to see that the custom menu works language COLUMN SWAP: test to see that the left and right columns change place
    • Affected Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Rank:
      39841

      Description

      This is a collection of issues related to RTL presentation.

        Issue Links

        Progress
        Resolved Sub-Tasks Unresolved Sub-Tasks

        Sub-Tasks

        1.
        RTL Theme fixes for Moodle 2 (theme/standardold) Sub-task Closed Nadav Kavalerchik
         
        2.
        RTL Theme fixes for Moodle 2 (theme/standard) Sub-task Closed Nadav Kavalerchik
         
        3.
        RTL Theme fixes for Moodle 2 (theme/splash) Sub-task Closed Nadav Kavalerchik
         
        4.
        RTL Theme fixes for Moodle 2 (theme/sky_high) Sub-task Closed Nadav Kavalerchik
         
        5.
        RTL Theme fixes for Moodle 2 (theme/serenity) Sub-task Closed Nadav Kavalerchik
         
        6.
        RTL Theme fixes for Moodle 2 (theme/overlay) Sub-task Closed Nadav Kavalerchik
         
        7.
        RTL Theme fixes for Moodle 2 (theme/nonzero) Sub-task Closed Nadav Kavalerchik
         
        8.
        RTL Theme fixes for Moodle 2 (theme/nimble) Sub-task Closed Nadav Kavalerchik
         
        9.
        RTL Theme fixes for Moodle 2 (theme/magazine) Sub-task Closed Nadav Kavalerchik
         
        10.
        RTL Theme fixes for Moodle 2 (theme/leatherbound) Sub-task Closed Nadav Kavalerchik
         
        11.
        RTL Theme fixes for Moodle 2 (theme/fusion) Sub-task Closed Nadav Kavalerchik
         
        12.
        RTL Theme fixes for Moodle 2 (theme/formfactor) Sub-task Closed Nadav Kavalerchik
         
        13.
        RTL Theme fixes for Moodle 2 (theme/formal_white) Sub-task Closed Mary Evans
         
        14.
        RTL Theme fixes for Moodle 2 (theme/brick) Sub-task Closed Nadav Kavalerchik
         
        15.
        RTL Theme fixes for Moodle 2 (theme/binarius) Sub-task Closed Nadav Kavalerchik
         
        16. RTL CSS fixes for Moodle 2 (lib/editor/tinymce) Sub-task Open moodle.com
         
        17.
        RTL Theme fixes for Moodle 2 (theme/arialist) Sub-task Closed Nadav Kavalerchik
         
        18.
        RTL Theme fixes for Moodle 2 (theme/boxxie) Sub-task Closed Nadav Kavalerchik
         
        19.
        RTL Theme fixes for Moodle 2 (theme/anomaly) Sub-task Closed Nadav Kavalerchik
         
        20.
        RTL UI fixes to Glossary activity (mod/glossary) Sub-task Closed Nadav Kavalerchik
         
        21. RTL UI fixes to Lesson activity (mod/lesson) Sub-task Open Nadav Kavalerchik
         
        22.
        RTL Theme fixes for Moodle 2 (theme/afterburner) Sub-task Closed Mary Evans
         

          Activity

          Hide
          Michael de Raadt added a comment -

          I've wrapped up these recently reported changes into a META issue.

          There have been a number of these in the past. I'm not sure if this is "Take 4". If this issue supersedes any of those previous issues, it would be good if you could close the old issues.

          Show
          Michael de Raadt added a comment - I've wrapped up these recently reported changes into a META issue. There have been a number of these in the past. I'm not sure if this is "Take 4". If this issue supersedes any of those previous issues, it would be good if you could close the old issues.
          Hide
          Nadav Kavalerchik added a comment -

          It is indeed Take 4.
          Thanks

          Show
          Nadav Kavalerchik added a comment - It is indeed Take 4. Thanks
          Show
          Nadav Kavalerchik added a comment - Please convert the following, to sub-tasks as well (since i am not sure how to do that) http://tracker.moodle.org/browse/MDL-32479 http://tracker.moodle.org/browse/MDL-32531 http://tracker.moodle.org/browse/MDL-32488 http://tracker.moodle.org/browse/MDL-32481
          Hide
          Nadav Kavalerchik added a comment - - edited

          And just to make sure you all know what this is all about,
          I am re-posting a comment (from the original META RTL MDL-30337):

          I have created and MDL for each theme with the relevant RTL changes. And linked it here.
          I have tested them, a little bit, on my local development system. They seem ok. but maybe... deep... inside there is some missing tweak that needs to be address as well. So, I separated them into different MDLs. please report any feedback to the relevant MDL.

          All themes can be applied together by using the (diff) branch [theme_rtl]:
          https://github.com/nadavkav/moodle/compare/theme_rtl

          If you are an RTL user and you are anxious to try the themes independently, you can download the themes packed into separate zip file from:
          https://github.com/nadavkav/Moodle2-Hebrew-plugins/tree/master/theme
          (Plus, some more 3rd party RTL themes)

          Enjoy

          Show
          Nadav Kavalerchik added a comment - - edited And just to make sure you all know what this is all about, I am re-posting a comment (from the original META RTL MDL-30337 ): I have created and MDL for each theme with the relevant RTL changes. And linked it here. I have tested them, a little bit, on my local development system. They seem ok. but maybe... deep... inside there is some missing tweak that needs to be address as well. So, I separated them into different MDLs. please report any feedback to the relevant MDL. All themes can be applied together by using the (diff) branch [theme_rtl] : https://github.com/nadavkav/moodle/compare/theme_rtl If you are an RTL user and you are anxious to try the themes independently, you can download the themes packed into separate zip file from: https://github.com/nadavkav/Moodle2-Hebrew-plugins/tree/master/theme (Plus, some more 3rd party RTL themes) Enjoy
          Hide
          Mary Evans added a comment - - edited

          Today is a holiday in the UK...

          Nadav, please tell me how you intend getting all these fixed?

          I personally would have had each one of these themes as individual branches and not as one gigantic commit!
          I just do not have any comprehension how this will get done, in fact I am getting worried.

          Please don't get me wrong, as each theme is OK, it is just the apparent complexity of it all that is my concern.

          Mary

          Show
          Mary Evans added a comment - - edited Today is a holiday in the UK... Nadav, please tell me how you intend getting all these fixed? I personally would have had each one of these themes as individual branches and not as one gigantic commit! I just do not have any comprehension how this will get done, in fact I am getting worried. Please don't get me wrong, as each theme is OK, it is just the apparent complexity of it all that is my concern. Mary
          Hide
          Nadav Kavalerchik added a comment -

          Happy Holiday

          Is it not easy to have all these changes on one branch?
          How splitting them into branches is more easy?
          (They are all integrated and dependent on each other.
          If i split base and canvas and boxxie... how can you test them?)

          Who is responsible for the integration? I would like to get him/her assigned to this issue as well,
          so I can understand what is best (easy) for moving this issue forward.

          Happy Holiday

          Show
          Nadav Kavalerchik added a comment - Happy Holiday Is it not easy to have all these changes on one branch? How splitting them into branches is more easy? (They are all integrated and dependent on each other. If i split base and canvas and boxxie... how can you test them?) Who is responsible for the integration? I would like to get him/her assigned to this issue as well, so I can understand what is best (easy) for moving this issue forward. Happy Holiday
          Hide
          Mary Evans added a comment -

          @Sam
          @Eloy

          I have added you as watchers on this very large RTL set of commits.
          Your input, with regards the best way forward with the various commits involved, would be invaluable.

          Thanks in advance
          Mary

          Show
          Mary Evans added a comment - @Sam @Eloy I have added you as watchers on this very large RTL set of commits. Your input, with regards the best way forward with the various commits involved, would be invaluable. Thanks in advance Mary
          Hide
          Mary Evans added a comment - - edited

          Hi Nadav,

          Some Holiday...it's cold and dull and no children playing in the street...quite miserable really.

          I have finally added all the other missing issues to this one now.

          I suppose looking at it from your point of view it will be easier to add all this as one branch. So you are probably right in your initial idea.

          I'm currently assigning these all to you now, so that you can take the weight off my shoulders!

          When you are ready to put this all together for integration let me know?
          It can be done from this page.

          Thanks

          Mary

          Show
          Mary Evans added a comment - - edited Hi Nadav, Some Holiday...it's cold and dull and no children playing in the street...quite miserable really. I have finally added all the other missing issues to this one now. I suppose looking at it from your point of view it will be easier to add all this as one branch. So you are probably right in your initial idea. I'm currently assigning these all to you now, so that you can take the weight off my shoulders! When you are ready to put this all together for integration let me know? It can be done from this page. Thanks Mary
          Hide
          Mary Evans added a comment -

          Hi Nadav,

          Are you ready to run with this yet? I'm just thinking there isn't much time left if your idea was to get this into Moodle 2.3?

          Show
          Mary Evans added a comment - Hi Nadav, Are you ready to run with this yet? I'm just thinking there isn't much time left if your idea was to get this into Moodle 2.3?
          Hide
          Nadav Kavalerchik added a comment -

          Actually...
          I was waiting for some code review. Just to make sure the "switch column blocks" technique is the right one and to make sure the custommenu renderer override is the right one too. With all the other CSS rules i am quite confident.

          Is there anything i can do the push this forward?

          Show
          Nadav Kavalerchik added a comment - Actually... I was waiting for some code review. Just to make sure the "switch column blocks" technique is the right one and to make sure the custommenu renderer override is the right one too. With all the other CSS rules i am quite confident. Is there anything i can do the push this forward?
          Hide
          Mary Evans added a comment - - edited

          The code looks OK and I am sure you are confident it works so let's go for it, because at the end of the day HQ have the final say, even if it works there may be something that upsets Moodle 2.3 so HQ will stop the integration process. They may even ask that each theme is done individually, They may even withdraw some themes as unsuitable and pick only a handful. I don't know, but the sooner this gets to be looked at the better.

          I'll set it in motion and see what happens.

          Mary

          Show
          Mary Evans added a comment - - edited The code looks OK and I am sure you are confident it works so let's go for it, because at the end of the day HQ have the final say, even if it works there may be something that upsets Moodle 2.3 so HQ will stop the integration process. They may even ask that each theme is done individually, They may even withdraw some themes as unsuitable and pick only a handful. I don't know, but the sooner this gets to be looked at the better. I'll set it in motion and see what happens. Mary
          Hide
          Nadav Kavalerchik added a comment -

          Great!

          Show
          Nadav Kavalerchik added a comment - Great!
          Hide
          Aparup Banerjee added a comment -

          Hi, the diff url is old and showing lots of entries. Trying to merge is causing quiet a few conflicts. This looks like it will have to be rebased.

          Show
          Aparup Banerjee added a comment - Hi, the diff url is old and showing lots of entries. Trying to merge is causing quiet a few conflicts. This looks like it will have to be rebased.
          Hide
          Nadav Kavalerchik added a comment -

          I have updated (17-5) my local origin/master and rebase all my commits on top of it. just now.
          and pushed it to my github.com/nadavkav account.

          Here is a link to all the recent commits, on top of "May 11, 2012 weekly release 2.3dev"
          https://github.com/nadavkav/moodle/commits/theme_rtl

          Show
          Nadav Kavalerchik added a comment - I have updated (17-5) my local origin/master and rebase all my commits on top of it. just now. and pushed it to my github.com/nadavkav account. Here is a link to all the recent commits, on top of "May 11, 2012 weekly release 2.3dev" https://github.com/nadavkav/moodle/commits/theme_rtl
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Hi,

          This isn't applying cleanly on top of origin/master. Can it be rebased ontop of that. thanks

          Show
          Dan Poltawski added a comment - Hi, This isn't applying cleanly on top of origin/master. Can it be rebased ontop of that. thanks
          Hide
          Nadav Kavalerchik added a comment -

          Just pushed a new update (from moodle/master 31-5-2012)
          and merged all those changes on top of it with a new branch named : "wip-MDL-30337-master-rtl_all_themes"
          https://github.com/nadavkav/moodle/tree/wip-MDL-30337-master-rtl_all_themes

          Show
          Nadav Kavalerchik added a comment - Just pushed a new update (from moodle/master 31-5-2012) and merged all those changes on top of it with a new branch named : "wip- MDL-30337 -master-rtl_all_themes" https://github.com/nadavkav/moodle/tree/wip-MDL-30337-master-rtl_all_themes
          Hide
          Mary Evans added a comment -

          Closing this as major fix is being done in MDL-30337

          Show
          Mary Evans added a comment - Closing this as major fix is being done in MDL-30337

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: