Moodle
  1. Moodle
  2. MDL-32846

YUI 2.9.0 experiencing some breakages after YUI 3.5.0 imported

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:
    • Rank:
      39900

      Description

      Noticed whilst testing MDL-32745:

      Open a course and choose to add a new URL.
      Open your JS console
      Refresh the page a few times

      Uncaught Error: extend failed, please check that all dependencies are included.

      Backtrace points to undefined Overlay var in build/menu/menu.js line 1187:

      YAHOO.lang.extend(Menu, Overlay, {
      

      We don't see this on every request

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          I am sorry, I can not reproduce this, could you include the full backtrace?

          Show
          Petr Škoda added a comment - I am sorry, I can not reproduce this, could you include the full backtrace?
          Hide
          Petr Škoda added a comment -

          Eh, who implemented the new up/down arrows for sections? They cause very annoying page movement when reloading the page, they should never appear when JS is enable imo.

          Show
          Petr Škoda added a comment - Eh, who implemented the new up/down arrows for sections? They cause very annoying page movement when reloading the page, they should never appear when JS is enable imo.
          Hide
          Petr Škoda added a comment -

          the same for move blocks icons

          Show
          Petr Škoda added a comment - the same for move blocks icons
          Hide
          Andrew Nicols added a comment -

          Sure. I can reliably reproduce using Chrome under Linux. I'm using a URL resource and this only seems to happen maybe 50% of the time.
          Rossiana has also been able to reproduce in testing MDL-32745.

          yui_combo.php:766 Uncaught Error: extend failed, please check that all dependencies are included.
          yui_combo.php:766 OB.extend
          yui_combo.php:1188 YAHOO.widget.MenuItem.parent
          yui_combo.php:6430 (anonymous function)
          
          Show
          Andrew Nicols added a comment - Sure. I can reliably reproduce using Chrome under Linux. I'm using a URL resource and this only seems to happen maybe 50% of the time. Rossiana has also been able to reproduce in testing MDL-32745 . yui_combo.php:766 Uncaught Error: extend failed, please check that all dependencies are included. yui_combo.php:766 OB.extend yui_combo.php:1188 YAHOO.widget.MenuItem.parent yui_combo.php:6430 (anonymous function)
          Hide
          Petr Škoda added a comment -

          could you please disable the combo loading? this does not tell me much about the source of problem

          Show
          Petr Škoda added a comment - could you please disable the combo loading? this does not tell me much about the source of problem
          Hide
          Andrew Nicols added a comment -

          I don't seem to be able to replicate with combo loading disabled...

          Show
          Andrew Nicols added a comment - I don't seem to be able to replicate with combo loading disabled...
          Hide
          Andrew Nicols added a comment -

          Reproduced with combo loading disabled

          Uncaught Error: extend failed, please check that all dependencies are included.
          yahoo.js:766 OB.extend
          menu.js:1188 YAHOO.widget.MenuItem.parent
          menu.js:6430 (anonymous function)
          
          Show
          Andrew Nicols added a comment - Reproduced with combo loading disabled Uncaught Error: extend failed, please check that all dependencies are included. yahoo.js:766 OB.extend menu.js:1188 YAHOO.widget.MenuItem.parent menu.js:6430 (anonymous function)
          Hide
          Petr Škoda added a comment -

          I managed to reproduce it only once in Chrome on OSX, works fine in all my other browsers it seems.

          Show
          Petr Škoda added a comment - I managed to reproduce it only once in Chrome on OSX, works fine in all my other browsers it seems.
          Hide
          Petr Škoda added a comment -

          Hmmm, YUI3.5 started to use asynchronous loader, maybe we should tell it that in case of YUI2 modules it needs to do it the old way, investigating...

          Show
          Petr Škoda added a comment - Hmmm, YUI3.5 started to use asynchronous loader, maybe we should tell it that in case of YUI2 modules it needs to do it the old way, investigating...
          Hide
          Petr Škoda added a comment -

          could you please try https://github.com/skodak/moodle/compare/cd41392c830...w19_MDL-32846_m23_syncyui2 ?
          If it does not help please try to add more async=false flags to modules defined in the find_module() in the same file, thanks.

          Show
          Petr Škoda added a comment - could you please try https://github.com/skodak/moodle/compare/cd41392c830...w19_MDL-32846_m23_syncyui2 ? If it does not help please try to add more async=false flags to modules defined in the find_module() in the same file, thanks.
          Hide
          Andrew Nicols added a comment -

          That seems to do the trick for me.

          Show
          Andrew Nicols added a comment - That seems to do the trick for me.
          Hide
          Petr Škoda added a comment -

          thanks a lot for the report and cooperation!

          Show
          Petr Škoda added a comment - thanks a lot for the report and cooperation!
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now.
          Just noting there is MDL-32837 to look at making the course page load less jarring, perhaps you'd like to dump some thoughts there.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now. Just noting there is MDL-32837 to look at making the course page load less jarring, perhaps you'd like to dump some thoughts there. Cheers Sam
          Hide
          Frédéric Massart added a comment -

          Tested successfully on master

          Show
          Frédéric Massart added a comment - Tested successfully on master
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

          Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: