Moodle
  1. Moodle
  2. MDL-32849

fix url rewriting support in new theme and JS slasharguments code

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1/ install IIS 7
      2/ install PHP using MS web platform installer
      3/ set up rewrite rules
      4/ test if JS, image and theme caching works with and without the rewrite rule
      5/ test that file names with utf-8 chars download with the rewrite rule enabled

      Show
      1/ install IIS 7 2/ install PHP using MS web platform installer 3/ set up rewrite rules 4/ test if JS, image and theme caching works with and without the rewrite rule 5/ test that file names with utf-8 chars download with the rewrite rule enabled
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w19_MDL-32849_m23_urlrewriting
    • Rank:
      39903

      Description

      I have forgotten that IIS requires full support for URL rewriting, see more info at:

      I am going to fix the code and improve docs.

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          I went through all installation pages and updated them to contain only valid information related to IIS, hopefully this should help admins to set up IIS properly.

          Show
          Petr Škoda added a comment - I went through all installation pages and updated them to contain only valid information related to IIS, hopefully this should help admins to set up IIS properly.
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr, changes look spot on and this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Petr, changes look spot on and this has been integrated now
          Hide
          Michael de Raadt added a comment -

          Hi, Petr.

          Could you please expand on step 2 of your testing instructions. How does one set up rewrite rules with IIS? What rules should be set up?

          Show
          Michael de Raadt added a comment - Hi, Petr. Could you please expand on step 2 of your testing instructions. How does one set up rewrite rules with IIS? What rules should be set up?
          Hide
          Petr Škoda added a comment -

          See the links in description if you need more info.

          Show
          Petr Škoda added a comment - See the links in description if you need more info.
          Hide
          Michael de Raadt added a comment -

          Test result: Success

          Tested in IIS with and without the rewrite rule.

          After adding the rule I was able to download files with non-ASCII characters in the filename.

          Show
          Michael de Raadt added a comment - Test result: Success Tested in IIS with and without the rewrite rule. After adding the rule I was able to download files with non-ASCII characters in the filename.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

          Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: