Moodle
  1. Moodle
  2. MDL-32860

Refactor the graded_users_iterator class

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.3
    • Component/s: Gradebook
    • Labels:
      None
    • Testing Instructions:
      Hide

      Testing is just a matter of making sure I didnt break anything. Do the following and check that it all still works.

      Do a grade export in each format. txt, xls, xml, ods.

      Go to the user report in the gradebook. Select and user from the drop down and check that displays fine.

      Show
      Testing is just a matter of making sure I didnt break anything. Do the following and check that it all still works. Do a grade export in each format. txt, xls, xml, ods. Go to the user report in the gradebook. Select and user from the drop down and check that displays fine.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-32860_user_iterator
    • Rank:
      39924

      Description

      Member variables have no php docs. Check all php docs while we're at it.

      All public member variables. Is that really necessary?

      There are some methods whose names start with and underscore. Are they meant to be private or protected?

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Also make the methods explicitly public, protected or private.

          Show
          Andrew Davis added a comment - Also make the methods explicitly public, protected or private.
          Hide
          Andrew Davis added a comment -

          Added a branch and testing instructions.

          Show
          Andrew Davis added a comment - Added a branch and testing instructions.
          Hide
          Sam Hemelryk added a comment -

          Changes look spot on thanks Andrew, putting this up for integration immediately

          Show
          Sam Hemelryk added a comment - Changes look spot on thanks Andrew, putting this up for integration immediately
          Hide
          Dan Poltawski added a comment -

          Thanks Andrew, i've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Andrew, i've integrated this now.
          Hide
          Adrian Greeve added a comment -

          I exported the grades into each of the different formats. No problems.
          Checked the user report in the gradebook. Also no problems.
          Test passed

          Show
          Adrian Greeve added a comment - I exported the grades into each of the different formats. No problems. Checked the user report in the gradebook. Also no problems. Test passed
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          Your work has made into the latest Moodle release!

          You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

          Show
          Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: